Repository navigation
Conversation
Previously, `partition_struct_attrs` rejected `#[schemars(...)]` before parsing `#[nutype(...)]` arguments, blocking users who derive external `schemars` (e.g. `schemars` 1.x) via `derive_unchecked(JsonSchema)`. Forward `#[schemars(...)]` in `partition_struct_attrs` and validate it in `gen_nutype` alongside `validate_serde_customization`, allowing `#[schemars(...)]` when `derive_unchecked` is present (unconditionally or via `cfg_attr`) and nutype's built-in `derive(JsonSchema)` is not used, while keeping the existing error otherwise. Fixes greyblake#263
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
partition_struct_attrsunconditionally rejected struct-level#[schemars(...)]attributes before#[nutype(...)]derive arguments were parsed, preventing#[schemars(...)]from being used alongside#[nutype(derive_unchecked(JsonSchema))](for example withschemars1.x).Defer
#[schemars(...)]validation togen_nutype(alongsidevalidate_serde_customization):#[schemars(...)]onto the generated struct whenderive_unchecked(...)(orcfg_attr(..., derive_unchecked(...))) is present and nutype's built-inderive(JsonSchema)is not used.derive(JsonSchema)is used or when noderive_uncheckedderive is present.Fixes #263