Fix the rendering of a Vimeo video in a Hosted content article#16091
Draft
deedeeh wants to merge 4 commits into
Draft
Fix the rendering of a Vimeo video in a Hosted content article#16091deedeeh wants to merge 4 commits into
deedeeh wants to merge 4 commits into
Conversation
deedeeh
force-pushed
the
dina/fix-hosted-article-vimeo-embed
branch
from
a69e6de to
059cb00
Compare
deedeeh
force-pushed
the
dina/fix-hosted-article-vimeo-embed
branch
2 times, most recently
from
7adf19e to
37df64a
Compare
deedeeh
changed the title
deedeeh
force-pushed
the
dina/fix-hosted-article-vimeo-embed
branch
from
37df64a to
619fef2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR fixes the
EmbedBlockElementVimeo video which exists in a Hosted Content article in DCAR as it's currently not visible on the page or in the DOM.There are two different scenarios in Hosted Content:
EmbedBlockElementthat shows a map or something similar.EmbedBlockElementwhich could be a video like VimeoWe need to check in the first case if we have a width coming from the data and if not we set a fallback of 100% and the height will be adjusted accordingly.
The second case we need to update the iframe height based on the viewport which what some existing components do as well to adjust the height of the embed.
There might be more edge cases coming along the way and we just need to update our logic to accommodate as much scenarios as possible.
Why?
Show Vimeo videos rendered as
EmbedBlockElementin Hosted Content DCAR.Screenshots