In article privacy notice bring privacy notice into blue box for signed in users#16160
Open
georgerichmond wants to merge 9 commits into
Conversation
…acy-notice-for-signed-in-users
georgerichmond
changed the title
georgerichmond
changed the base branch from
main
to
16124-in-article-privacy-notice-shorter-privacy-notice-for-signed-in-users
georgerichmond
added
Do not merge ⚠️
feature
There was a problem hiding this comment.
Pull request overview
Moves the signed-in privacy notice for the in-article newsletter signup card from outside the card container to within the card layout, updating related props/usages and aligning tests/stories with the new behaviour.
Changes:
- Render the privacy notice from
NewsletterSignupForm(with signed-in-specific container styling) instead ofNewsletterSignupCardContainer. - Remove the
hidePrivacyMessageprop and clean up callers, tests, and Storybook stories accordingly. - Simplify conditional rendering around the marketing toggle and privacy message placement.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| dotcom-rendering/src/components/NewsletterSignupForm.island.tsx | Moves privacy notice rendering outside the <form> and adds signed-in styling (border/top padding) for the card. |
| dotcom-rendering/src/components/NewsletterSignupForm.island.test.tsx | Removes hidePrivacyMessage plumbing and updates affected tests. |
| dotcom-rendering/src/components/NewsletterSignupForm.island.stories.tsx | Removes the HidePrivacyMessage story that depended on the removed prop. |
| dotcom-rendering/src/components/NewsletterSignupCardContainer.tsx | Removes the signed-in privacy notice previously rendered outside the card. |
| dotcom-rendering/src/components/EmailSignUpWrapper.stories.tsx | Removes hidePrivacyMessage args; story set updated (one story now redundant). |
| dotcom-rendering/src/components/EmailSignUpWrapper.island.tsx | Removes hidePrivacyMessage prop usage and always renders NewsletterPrivacyMessage in the control (EmailSignup) branch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
Bot
removed
the
run_chromatic
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
mgosz-guardian
approved these changes
Jun 15, 2026
Base automatically changed from
16124-in-article-privacy-notice-shorter-privacy-notice-for-signed-in-users
to
main
June 16, 2026 12:24
…y-notice-into-blue-box-for-signed-in-users # Conflicts: # dotcom-rendering/src/components/NewsletterSignupCardContainer.tsx # dotcom-rendering/src/components/NewsletterSignupForm.island.tsx
…y-notice-into-blue-box-for-signed-in-users
github-actions
Bot
removed
the
run_chromatic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Moves the privacy message for signed-in users for the in-article signup card inside the card rather than outside, with a grey line.
Why?
Based on feedback from colleagues
Screenshots