Wire up cricket header in live blog#16161
Open
marjisound wants to merge 3 commits into
Open
Conversation
marjisound
force-pushed
the
wire-up-cricket-header-in-live-blog
branch
from
f3385e4 to
b5311ff
Compare
The tests are still not covering all scenarios. This will need to be improved after the tabs logic is implemented
marjisound
force-pushed
the
wire-up-cricket-header-in-live-blog
branch
from
df60e72 to
d73d4c6
Compare
github-actions
Bot
removed
the
run_chromatic
Jakeii
reviewed
Jun 16, 2026
Comment on lines
+1114
to
+1123
| football: { | ||
| footballMatchLeagueName: string; | ||
| footballMatchLeagueUrl: string; | ||
| footballMatchHeaderUrl?: string; | ||
| footballMatchUrl?: string; | ||
| }; | ||
| cricket: { | ||
| cricketMatchHeaderUrl?: string; | ||
| isCricketRedesignEnabled: boolean; | ||
| }; |
Member
There was a problem hiding this comment.
Could these props be derived in the Header component? Looks like they mostly come from the article
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Wiring up cricket header into cricket live blog
This PR adds a new
CricketMatchHeaderWrappercomponent that wraps theCricketMatchHeader. The purpose of having this component is for testing. This way we can easily add storybook interaction tests using the play function since the logic forgetHeaderDatacan be passed to the component as a prop, so the consumer decides how to get the data.The
CricketMatchHeaderWrapperis used in theLiveLayoutwhen the live blog is for a cricket match. This is now behind a feature flag and you'd need to opt-in in order to see it (https://m.code.dev-theguardian.com/ab-tests/opt-in/webx-cricket-redesign:enable).Note: Currently I have added some interaction tests in CricketMatchHeader storybook, but the tests need to get expanded and improved after we have the tab logic for the scorecard.
Screenshots
Tested in CODE.