Skip to content

Fix GitHub capitalization in sitemap footer diagram#8646

Merged
dvernon5 merged 1 commit into
hackforla:gh-pagesfrom
egcuriel:fix/8488-sitemap-github-typo
May 21, 2026
Merged

Fix GitHub capitalization in sitemap footer diagram#8646
dvernon5 merged 1 commit into
hackforla:gh-pagesfrom
egcuriel:fix/8488-sitemap-github-typo

Conversation

@egcuriel
Copy link
Copy Markdown
Member

Fixes #8488

What changes did you make?

  • Fix GitHub capitalization in sitemap footer diagram

Why did you make the changes (we will use this info to test)?

  • To correctly display the GitHub company name according to standard branding.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link
Copy Markdown

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b egcuriel-fix/8488-sitemap-github-typo gh-pages
git pull https://github.com/egcuriel/website.git fix/8488-sitemap-github-typo

@github-actions github-actions Bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe P-Feature: Sitemap https://www.hackforla.org/sitemap/ size: 0.25pt Can be done in 0.5 to 1.5 hours feature: spelling labels May 19, 2026
@sushma110396 sushma110396 self-requested a review May 19, 2026 17:18
@sushma110396
Copy link
Copy Markdown
Member

Review ETA: 6 PM 05/19/26
Availability: Weekdays after 6PM PST

Copy link
Copy Markdown
Member

@sushma110396 sushma110396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! You have followed all the required steps correctly:

  • Pull request has the correct branch name
  • There is a linked issue
  • File change looks good.
  • Change is reflecting correctly on the website too. I have verified in my local.

PR approved.

@egcuriel
Copy link
Copy Markdown
Member Author

Availability:

  • M - Sun (5 pm - 11 pm)

Thank you!

@castillios castillios self-requested a review May 20, 2026 00:03
@castillios
Copy link
Copy Markdown
Member

Review ETA: 5/19 by EOD
Availability: Weekdays before 7PM

Copy link
Copy Markdown
Member

@castillios castillios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @egcuriel,
Great job on the PR! I reviewed your changes locally and the updated sitemap.jpg showed up & looks good.

Done correctly

  • sitemap.jpg has been updated and GitHub capitalization has been fixed
  • Issue properly linked and correctly assigned yourself
  • Action items checked off on issue, CodeQL alerts checked off on PR
  • Screenshots of visual changes have been included

Suggested changes

  • Availability not included in original issue. No need to include avail in PR itself as only reviewers need to
  • Project status on original issue not set to In progress (see below)

The project status is set to Done in the OG issue. I believe you'll be okay leaving it as In progress.
Once your PR is approved and merged, the issue will automatically be set to Done as per the CONTRIBUTING.md
(Though if any merge team or team leads can correct me, please do so!)

Otherwise, I've approved the PR. Great work and thank you for your contribution!

@github-project-automation github-project-automation Bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board May 20, 2026
@dvernon5 dvernon5 merged commit 5cea104 into hackforla:gh-pages May 21, 2026
10 checks passed
@dvernon5
Copy link
Copy Markdown
Member

@egcuriel Thank you for your contributions. The sitemap modifications are showing in the testing environment. Wonderful job!

@egcuriel
Copy link
Copy Markdown
Member Author

Thanks everyone!

@egcuriel egcuriel deleted the fix/8488-sitemap-github-typo branch May 26, 2026 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: spelling good first issue Good for newcomers P-Feature: Sitemap https://www.hackforla.org/sitemap/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Github to GitHub in Footer of Sitemap Image

4 participants