Fix GitHub capitalization in sitemap footer diagram#8646
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 6 PM 05/19/26 |
sushma110396
left a comment
There was a problem hiding this comment.
Good job! You have followed all the required steps correctly:
- Pull request has the correct branch name
- There is a linked issue
- File change looks good.
- Change is reflecting correctly on the website too. I have verified in my local.
PR approved.
|
Availability:
Thank you! |
|
Review ETA: 5/19 by EOD |
There was a problem hiding this comment.
Hi @egcuriel,
Great job on the PR! I reviewed your changes locally and the updated sitemap.jpg showed up & looks good.
Done correctly
sitemap.jpghas been updated and GitHub capitalization has been fixed- Issue properly linked and correctly assigned yourself
- Action items checked off on issue, CodeQL alerts checked off on PR
- Screenshots of visual changes have been included
Suggested changes
- Availability not included in original issue. No need to include avail in PR itself as only reviewers need to
- Project status on original issue not set to
In progress(see below)
The project status is set to Done in the OG issue. I believe you'll be okay leaving it as In progress.
Once your PR is approved and merged, the issue will automatically be set to Done as per the CONTRIBUTING.md
(Though if any merge team or team leads can correct me, please do so!)
Otherwise, I've approved the PR. Great work and thank you for your contribution!
|
@egcuriel Thank you for your contributions. The sitemap modifications are showing in the testing environment. Wonderful job! |
|
Thanks everyone! |
Fixes #8488
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied