Correct Oxford Comma in Join Us Page (#8513)#8650
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
ETA: 5/21 EOD |
castillios
left a comment
There was a problem hiding this comment.
Hi @egcuriel! Excellent work on the PR! The screenshots are well organized, and it's awesome that you included both desktop and mobile views since the OG issue mentioned checking both.
Everything in the OG issue & PR looks good: issue is self-assigned with availability included, action items are checked off, CodeQL alerts are checked off. Ran it locally and the comma is updated. Approved, thank you for your contribution!
|
ETA: 5/22 EOD |
sushma110396
left a comment
There was a problem hiding this comment.
Change looks good! I have verified locally. All the required steps have been followed correctly. I like how you have provided screenshots of visual changes for both desktop and mobile views. Well done!
PR approved.
Fixes #8513
What changes did you make?
something, growing their experiences, portfolios and ability to work on
to
something, growing their experiences, portfolios, and ability to work on
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Desktop
Mobile
Visuals after changes are applied
Desktop
Mobile