Skip to content

Correct Oxford Comma in Join Us Page (#8513)#8650

Open
egcuriel wants to merge 1 commit into
hackforla:gh-pagesfrom
egcuriel:egcuriel/8513-fix-oxford-comma
Open

Correct Oxford Comma in Join Us Page (#8513)#8650
egcuriel wants to merge 1 commit into
hackforla:gh-pagesfrom
egcuriel:egcuriel/8513-fix-oxford-comma

Conversation

@egcuriel
Copy link
Copy Markdown
Member

@egcuriel egcuriel commented May 22, 2026

Fixes #8513

What changes did you make?

  • Corrected the Join Us text to use the Oxford comma, from
    something, growing their experiences, portfolios and ability to work on
    to
    something, growing their experiences, portfolios, and ability to work on

Why did you make the changes (we will use this info to test)?

  • To add a comma in between "portfolios" and "and"

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied
Desktop
Mobile
Visuals after changes are applied
Desktop
Mobile

@github-actions
Copy link
Copy Markdown

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b egcuriel-egcuriel/8513-fix-oxford-comma gh-pages
git pull https://github.com/egcuriel/website.git egcuriel/8513-fix-oxford-comma

@github-actions github-actions Bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe P-Feature: Join Page https://www.hackforla.org/join size: 0.25pt Can be done in 0.5 to 1.5 hours feature: spelling labels May 22, 2026
@castillios castillios self-requested a review May 22, 2026 01:45
@castillios
Copy link
Copy Markdown
Member

ETA: 5/21 EOD
Availability: Weekdays before 7PM, all day Sunday

Copy link
Copy Markdown
Member

@castillios castillios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @egcuriel! Excellent work on the PR! The screenshots are well organized, and it's awesome that you included both desktop and mobile views since the OG issue mentioned checking both.

Everything in the OG issue & PR looks good: issue is self-assigned with availability included, action items are checked off, CodeQL alerts are checked off. Ran it locally and the comma is updated. Approved, thank you for your contribution!

@sushma110396 sushma110396 self-requested a review May 22, 2026 03:49
@sushma110396
Copy link
Copy Markdown
Member

ETA: 5/22 EOD
Availability: Weekdays after 6PM PST

Copy link
Copy Markdown
Member

@sushma110396 sushma110396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good! I have verified locally. All the required steps have been followed correctly. I like how you have provided screenshots of visual changes for both desktop and mobile views. Well done!

PR approved.

@github-project-automation github-project-automation Bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: spelling good first issue Good for newcomers P-Feature: Join Page https://www.hackforla.org/join role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Status: PRs ✅ waiting for merge team

Development

Successfully merging this pull request may close these issues.

Correct Oxford Comma in Join Us Page

3 participants