Skip to content

added github-handle variable for Mark Jackson - #8740

Merged
castillios merged 1 commit into
hackforla:gh-pagesfrom
yepezjuan:add-github-handle-7795
Aug 20, 2026
Merged

added github-handle variable for Mark Jackson#8740
castillios merged 1 commit into
hackforla:gh-pagesfrom
yepezjuan:add-github-handle-7795

Conversation

@yepezjuan

@yepezjuan yepezjuan commented Aug 19, 2026

Copy link
Copy Markdown
Member

Fixes #7795

What changes did you make?

  • added variable github-handle to public-tree-map.md

Why did you make the changes (we will use this info to test)?

  • that was the action item, needed to add "github-handle"
  • "Eventually github-handle will replace the github and picture variables, reducing redundancy in the project file."

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

@github-actions

Copy link
Copy Markdown

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b yepezjuan-add-github-handle-7795 gh-pages
git pull https://github.com/yepezjuan/website.git add-github-handle-7795

@github-actions github-actions Bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours HLC: C Homepage Launch Countdown Could Have labels Aug 19, 2026

@cchrizzle cchrizzle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yepezjuan,

Good job on your first submission! You followed the instructions to add the "github-handle" line and indent using spaces and completed the main request, just a couple of things:

  1. I think you might have missed the screenshots section with the before and after pictures (if applicable). Can you update it to include pictures, or if there's no visual changes just say "No visual changes to the website" (I think it's included in the template, that's what I put for my pull request since mine didn't have any).
  2. Check the appropriate checkbox under the "CodeQL Alerts" section. You can find the results of the scan further down your pull request (all checks passed for yours so you can just search "All checks have passed" to find where it is for future reference.
  3. Some minor formatting issues under "What changes did you make" and "Why did you make the changes" with the empty bullet points. You can just remove those if there's nothing there.

Just get those addressed and it'll be perfect! Let me know once you do so I can approve this.

@github-project-automation github-project-automation Bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Aug 19, 2026
@cchrizzle

cchrizzle commented Aug 19, 2026

Copy link
Copy Markdown
Member

Availability:

MWF: Before 10:30am and 7-8pm
TTh: Before 12pm and 7-8pm

@palak-hellowrld

palak-hellowrld commented Aug 19, 2026

Copy link
Copy Markdown
Member

Review ETA: 11:30 PM 8/18/2026
Availability: M-F: 1pm-8pm

@palak-hellowrld palak-hellowrld left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yepezjuan ! Great work on correctly updating the code and resolving the issue. Here's a summary:

  • Linked issue is present
  • No errors during local testing
  • No visual changes to the website
  • Branches are correctly set

@cchrizzle
cchrizzle dismissed their stale review August 19, 2026 23:29

Changes implemented!

@cchrizzle cchrizzle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yepezjuan Great job on the changes, approved!

@github-project-automation github-project-automation Bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Aug 19, 2026
@castillios

Copy link
Copy Markdown
Member

Thank you @yepezjuan and reviewers for your contribution! Changes look perfect. Just one small thing, be sure to check off action items in the corresponding issue as you complete its tasks. I'm merging this PR right now, great work!

@castillios
castillios merged commit 5d9664f into hackforla:gh-pages Aug 20, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers HLC: C Homepage Launch Countdown Could Have P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Mark Jackson in public-tree-map.md

4 participants