added github-handle variable for Mark Jackson - #8740
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
cchrizzle
left a comment
There was a problem hiding this comment.
Hi @yepezjuan,
Good job on your first submission! You followed the instructions to add the "github-handle" line and indent using spaces and completed the main request, just a couple of things:
- I think you might have missed the screenshots section with the before and after pictures (if applicable). Can you update it to include pictures, or if there's no visual changes just say "No visual changes to the website" (I think it's included in the template, that's what I put for my pull request since mine didn't have any).
- Check the appropriate checkbox under the "CodeQL Alerts" section. You can find the results of the scan further down your pull request (all checks passed for yours so you can just search "All checks have passed" to find where it is for future reference.
- Some minor formatting issues under "What changes did you make" and "Why did you make the changes" with the empty bullet points. You can just remove those if there's nothing there.
Just get those addressed and it'll be perfect! Let me know once you do so I can approve this.
|
Availability: MWF: Before 10:30am and 7-8pm |
|
Review ETA: 11:30 PM 8/18/2026 |
palak-hellowrld
left a comment
There was a problem hiding this comment.
Hi @yepezjuan ! Great work on correctly updating the code and resolving the issue. Here's a summary:
- Linked issue is present
- No errors during local testing
- No visual changes to the website
- Branches are correctly set
cchrizzle
left a comment
There was a problem hiding this comment.
@yepezjuan Great job on the changes, approved!
|
Thank you @yepezjuan and reviewers for your contribution! Changes look perfect. Just one small thing, be sure to check off action items in the corresponding issue as you complete its tasks. I'm merging this PR right now, great work! |
Fixes #7795
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)