Use absolute URL for logo in README - #11
Merged
Merged
Conversation
Contributor
|
@bruno-f-cruz Should we use a sha-pinned commit URL rather than a link to main? This way it might be easier to guarantee consistency and formatting even in case we ever refactor the repo structure or contents in the future. |
bruno-f-cruz
force-pushed
the
fix-readme-absolute-logo-url
branch
from
July 25, 2026 15:59
9026a85 to
262fc0d
Compare
glopesdev
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the README logo![]()
source from a repo-relative path (docs/assets/logo.svg) to an absolute URL (https://raw.githubusercontent.com/harp-tech/pyharp/main/docs/assets/logo.svg).
The README is used as the long-description metadata for the PyPI package page. PyPI renders that description in isolation from the GitHub repo, so a repo-relative image path has no base to resolve against and evaluates to a broken link. Using an absolute raw.githubusercontent.com URL makes the image resolve correctly regardless of where the README is rendered (PyPI, GitHub, or elsewhere).