Skip to content

Document Tech Lead use of PyHC Standards Evaluator; drop stale 2020 dates#382

Merged
sapols merged 1 commit into
mainfrom
shawn-submission-docs
May 26, 2026
Merged

Document Tech Lead use of PyHC Standards Evaluator; drop stale 2020 dates#382
sapols merged 1 commit into
mainfrom
shawn-submission-docs

Conversation

@sapols
Copy link
Copy Markdown
Contributor

@sapols sapols commented May 26, 2026

Summary

Two related updates to the PyHC project submission docs:

  1. Document the PyHC Tech Lead's use of the PyHC Standards Evaluator. When a submitter opens a PR with their self-evaluation grading badges, the Tech Lead now generates a standards report using the evaluator AI tool and compares it against the self-evaluation. If they agree, the PR can be merged at the Tech Lead's discretion; if they disagree, the Tech Lead discusses with the submitter in the PR until a final set of grades is agreed upon (Tech Lead has final say). The review process itself is unchanged — the Tech Lead has always done this — there's just an AI tool to help now. Also corrects "a PyHC developer will...approve it unconditionally" to "the PyHC Tech Lead will...approve at the Tech Lead's discretion."
  2. Drop stale "Spring 2020 meeting" / "by 2020" framing in both the submission instructions and the grading guidelines. Replaced with future-tense wording so the intent (we will eventually start enforcing red-grade rejections) is preserved without the dead deadline.

Files changed:

  • _pages/docs/adding_to_pyhc_project_list.md (Jekyll/website version) — both updates
  • _pyhc_projects/adding_to_pyhc_project_list.md (GitHub markdown version) — both updates, kept in sync with the Jekyll copy
  • _pyhc_projects/pyhc_project_grading_guidelines.md — 2020-date cleanup only

A matching PR in pyhc-standards-evaluator will apply the same 2020-date cleanup to that repo's byte-identical copy of pyhc_project_grading_guidelines.md.

Test plan

  • Render the _pages/docs/adding_to_pyhc_project_list.md page locally (or in the PR preview if available) and confirm the updated paragraph renders correctly, with the evaluator link working.
  • Spot-check that no "2020" references remain in any of the three modified files.
  • Confirm the two adding_to_pyhc_project_list.md copies remain aligned in content (only formatting differences).

…ates

- Note that the PyHC Tech Lead reviews each submission PR and uses the
  PyHC Standards Evaluator (https://github.com/heliophysicsPy/pyhc-standards-evaluator)
  to generate a standards report, comparing it against the submitter's
  self-evaluation. The Tech Lead has final say on grades and PR approval.
- Replace the "Spring 2020 meeting" / "by 2020" promises (now 6+ years
  stale) with future-tense wording, preserving the original intent.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@sapols
Copy link
Copy Markdown
Contributor Author

sapols commented May 26, 2026

@jibarnum adding you for visibility. These changes are minimal and I know you're busy this week, so I'm gonna go ahead and merge. But please feel free to look over the wording changes, and if you'd like to say anything differently just say so and I'll update accordingly!

@sapols sapols merged commit e57ce91 into main May 26, 2026
1 check passed
@sapols sapols deleted the shawn-submission-docs branch May 26, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant