Skip to content

Lib data members fix1 - #604

Merged
xeus2001 merged 100 commits into
lib_datafrom
lib_data_members_fix1
Jul 22, 2026
Merged

Lib data members fix1#604
xeus2001 merged 100 commits into
lib_datafrom
lib_data_members_fix1

Conversation

@xeus2001

@xeus2001 xeus2001 commented Jun 10, 2026

Copy link
Copy Markdown
Member

No description provided.

kkin-here
kkin-here reviewed Jun 11, 2026
View reviewed changes
Comment thread .claude/skills/naksha-test/SKILL.md
./gradlew :here-naksha-app-service:jvmTest
```

# Common Issues

@kkin-here kkin-here Jun 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what I tried with my skills is to add a mention of self-evolution: something like "Update this skill If some instructions are out-of-date or there is new guidance/steps required". Usually it's enough to have agents self-evolve the skill, keeping it up-to-date

xeus2001 and others added 23 commits June 19, 2026 11:36
@xeus2001
Add skill for AI to run tests.
77970cf 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Minor fix in delete and update feature tests.
7a0451f 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Add JSON path to standard members.
d5ac124 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Replaced hardcoded strings with StandardMembers references.
7432781 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Import StandardMembers
6501f6b 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Renamed map into path in members, because thats what it actually is.
efab25b 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Improve the member handling, partially removed the hardcoded workarou…
a763efb 
…nds.

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Little architectural overview generated by AI.
a0b1d0b 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Fix errors left over from conflicts after rebasing.
69df3e3 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Improve member handling, so that the path is always used and features…
06e3fa3 
… can be put together as wanted.

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Add support for BookType, delete metadata and repalce with members. F…
3ebe8e3 
…ix tuple encoding and decoding.

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Fix compilation errors that were the result of the previous modificat…
64abbf4 
…ions, still some left.

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Latest state, work in progress.
7879c57 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Fix minor issue in JBON2 spec.
2cac66d 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Next bunch of fixes about the members not being hardcoded.
c512529 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@kkin-here @xeus2001
Handle Xyz members (#606)
cdfc307 
Signed-off-by: kkin-here <284318677+kkin-here@users.noreply.github.com>
@xeus2001
Next round of AI code cleanup, now members are as they should be, sti…
e5fdf06 
…ll much code is not up-to-date.

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Fix more issues in PgRows and related.
6b7cb81 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Some more fixes.
b006742 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Fix catalog, add some comments where needed, deprecate usage of encod…
5c56227 
…ing.

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
More fixes in PgCatalog, session, transaction, aso.
4db5ad6 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Fix more compiler issues.
5ae2aa7 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
More minor fixes, mainly naming and comments.
739d1cc 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
xeus2001 force-pushed the lib_data_members_fix1 branch from d4cc3f5 to 739d1cc Compare June 19, 2026 09:41
xeus2001 and others added 5 commits June 19, 2026 13:27
@xeus2001
Rename more maps into catalogs
998e890 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Start fixing query builder.
426d3c6 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@gunplar
fix Write classes
c63ae99 
Signed-off-by: phmai <phuc.mai@here.com>
@xeus2001
Add dedicated members as helper, specifically for query convertion.
2d0c875 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Add support for member queries.
e2ac769 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
kkin-here and others added 28 commits July 14, 2026 17:51
@kkin-here
fix tuple-number tests, seed admin-catalog history partitions (#619)
6734a65 
Signed-off-by: kkin-here <284318677+kkin-here@users.noreply.github.com>
@xeus2001
Upgrade libraries, JVM and Kotlin. (#620)
d5e85ac 
* Merged JVM target code so we can change in properties, upgraded gradle to 9.6.1, upgraded libraries, upgraded to Kotlin 2.4.0, upgraded to JVM 25.

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>

* Fix JavaScript compilation, allow compiler to convert Long into BigInt and vice versa.

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>

* Fix relocated datetime classes.

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>

---------

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Cleanup build files, remove long deprecated stuff, ensure all version…
7c638a3 
…s are in libs.versions.toml. (#622)

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@gunplar
missing list type handling and TODO
f824a84 
Signed-off-by: phmai <phuc.mai@here.com>
@xeus2001
Fix missing static annotation in getTestStorageId implementation.
2ba2cfb 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Add AI generated debug information for app-service.
562cdd0 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Add explicit type to avoid error, previous in kotlin 2.2 this was onl…
b2bddf7 
…y a warning.

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Adjust test, for some reason creation of internal classes work now.
01c2ed3 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Fix imports in lib-psql tests.
e760e1d 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Fix lib-view tests for removed CommonTestConstants.
92f6450 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Add support into ApiTest and CommonApiTestSetup to gather the databas…
b9aa311 
…e, catalog, and collection identifiers and numbers.

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Fix schema/catalog and collection detection, accept that sometimes we…
cc006fa 
… simply do not know.

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@kkin-here
Fix cli tests (#623)
5d4af9e 
* Fix cli tests

Signed-off-by: kkin-here <284318677+kkin-here@users.noreply.github.com>

* Adjust forking, refs, fix tests

Signed-off-by: kkin-here <284318677+kkin-here@users.noreply.github.com>

---------

Signed-off-by: kkin-here <284318677+kkin-here@users.noreply.github.com>
@kkin-here
Add TODO to PgSession for cache race condition
66447e0 
Signed-off-by: kkin-here <284318677+kkin-here@users.noreply.github.com>
@gunplar
Unit tests activity log (#624)
a5818ca 
* fix tests 1 left

Signed-off-by: phmai <phuc.mai@here.com>

* last activity log test

Signed-off-by: phmai <phuc.mai@here.com>

---------

Signed-off-by: phmai <phuc.mai@here.com>
@gunplar
allow features in response to have different order
0d6924d 
Signed-off-by: phmai <phuc.mai@here.com>
@xeus2001
Lib data fix view union (#625)
66be527 
* Added missing documentation.

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>

* Just modify the code so I can set breakpoint.

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>

* Fix code, it was using wrong timeout, remove streaming API usage to be able to step through code in debug mode, simplify code avoid extra loops.

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>

* Create helper class to generate random new UUIDs.

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>

* Finally fix the test, it was just missing to inject the UUID into the mocked response.

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>

---------

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Refactor Action, Guid, NakshaError, NakshaException, TupleNumber, Tul…
23af77a 
…eNUmberVariant, and Version into lib-base. (#626)

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Added support for TupleNumber into JbDecoder2 and JbEncoder2, fixing …
fde429b 
…SpaceApiTest. (#627)

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Improve JVM target configuration for projects without JavaScript usage.
7b985db 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@gunplar
fix patch feature test (#629)
8135c4b 
* fix PatchFeatureTest

Signed-off-by: phmai <phuc.mai@here.com>

* clarify TODO

Signed-off-by: phmai <phuc.mai@here.com>

---------

Signed-off-by: phmai <phuc.mai@here.com>
@kkin-here
Clean up prepareWrite, session-scoped cache (#628)
8e71f92 
Signed-off-by: kkin-here <284318677+kkin-here@users.noreply.github.com>
@xeus2001
Updated ReadFeaturesByTileTest to ignore feature order. (#630)
b9eb5d0 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Add valid UUIDs refering to HEAD to fix UUID parsing. (#632)
acf70b5 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Add missing UUID to result file.
e3f8373 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@gunplar
fix read by bbox and TODO clarifications for PatchFeature REST (#631)
0271d58 
* fix read by bboy and TODO clarifications for PatchFeature REST

Signed-off-by: phmai <phuc.mai@here.com>

* todo

Signed-off-by: phmai <phuc.mai@here.com>

---------

Signed-off-by: phmai <phuc.mai@here.com>
@xeus2001
Fix Tuple.encodeFeature, fix PgWriter.prepareWrite, rename TagsMember…
9d7fe9b 
… to TagMapMember, minor changes ...

Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
Update test.md
5308f91 
Signed-off-by: Alexander Lowey-Weber <alexander.weber@here.com>
@xeus2001
xeus2001 merged commit 5308f91 into lib_data Jul 22, 2026
1 check failed
@xeus2001
xeus2001 deleted the lib_data_members_fix1 branch July 22, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkin-here kkin-here kkin-here left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xeus2001 @kkin-here @gunplar