Move runtime ownership into druid-cli#76
Open
MarcStdt wants to merge 15 commits into
Open
Conversation
Contributor
|
- Introduced a new `namespace` field in the OpenAPI specification for runtime resources, applicable to Kubernetes backends. - Updated the runtime supervisor and related services to handle the new namespace parameter during scroll creation and management. - Enhanced error handling and logging in the runtime daemon for better observability. - Refactored related tests to accommodate the namespace changes and ensure proper functionality.
…t settings - Added UUID generation for runtime scroll IDs when omitted during creation, ensuring unique identifiers. - Implemented a timeout for HTTP clients in the OpenAPI client to improve reliability. - Updated OpenAPI specifications and related documentation to reflect changes in ID handling. - Refactored error handling in the runtime supervisor to manage scroll creation more effectively. - Enhanced tests to cover new functionality and ensure robustness in scroll management.
- Introduced a new `RuntimeWorkerCallbackConfig` structure to manage callback settings for the runtime daemon. - Enhanced the `runRuntimeDaemon` function to load environment variables and configure worker callbacks dynamically. - Added `openWorkerCallbackListener` function to handle TCP listener creation for worker callbacks. - Updated the Docker backend to support worker callback defaults and URL generation after listener setup. - Added unit tests for the new callback listener functionality and its integration with the runtime daemon.
- Added support for routing assignments in the runtime command structure, allowing for better management of network configurations. - Introduced a new error type for non-retryable command errors, improving error handling in the queue manager and procedure launcher. - Updated the Docker backend to utilize routing information during container creation and command execution. - Enhanced unit tests to validate the new routing functionality and error handling improvements.
MarcStdt
force-pushed
the
feat/druid-k8s-runtime-owner
branch
from
5147438 to
a1c9856
Compare
MarcStdt
commented
May 25, 2026
| fi | ||
|
|
||
| # Map envs to args (--cwd = scroll dir, --config = path to .druid.yaml) | ||
| if [ ! -z "${DRUID_JWKS_SERVER}" ]; |
Contributor
Author
There was a problem hiding this comment.
.docker/entrypoint.sh should manage all env specific configurations. envs should not be definied directly in the go code, (check how it was done before)
Comment on lines
+26
to
+90
| /api/v1/files: | ||
| get: | ||
| operationId: getFile | ||
| tags: [files] | ||
| summary: Read a file from the runtime root | ||
| parameters: | ||
| - $ref: '#/components/parameters/FilePath' | ||
| responses: | ||
| '200': | ||
| description: File contents | ||
| content: | ||
| text/plain: | ||
| schema: | ||
| type: string | ||
| application/octet-stream: | ||
| schema: | ||
| type: string | ||
| format: binary | ||
| '400': | ||
| $ref: '#/components/responses/BadRequest' | ||
| '404': | ||
| $ref: '#/components/responses/NotFound' | ||
| head: | ||
| operationId: headFile | ||
| tags: [files] | ||
| summary: Check if a runtime file exists | ||
| parameters: | ||
| - $ref: '#/components/parameters/FilePath' | ||
| responses: | ||
| '200': | ||
| description: File exists | ||
| '400': | ||
| $ref: '#/components/responses/BadRequest' | ||
| '404': | ||
| $ref: '#/components/responses/NotFound' | ||
| put: | ||
| operationId: putFile | ||
| tags: [files] | ||
| summary: Write a file into the runtime root | ||
| parameters: | ||
| - $ref: '#/components/parameters/FilePath' | ||
| requestBody: | ||
| required: true | ||
| content: | ||
| text/plain: | ||
| schema: | ||
| type: string | ||
| application/octet-stream: | ||
| schema: | ||
| type: string | ||
| format: binary | ||
| responses: | ||
| '204': | ||
| description: File written | ||
| '400': | ||
| $ref: '#/components/responses/BadRequest' | ||
| options: | ||
| operationId: optionsFile | ||
| tags: [files] | ||
| summary: Return CORS/WebDAV file access options | ||
| parameters: | ||
| - $ref: '#/components/parameters/FilePath' | ||
| responses: | ||
| '204': | ||
| description: Options returned |
Contributor
Author
There was a problem hiding this comment.
use the builtin webdav server dont construct types or routes on your own!
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| var CommandCommand = &cobra.Command{ |
Contributor
Author
There was a problem hiding this comment.
do one command per file, also add this to the AGENTS.md, split up command.go
| Short: "Inspect and attach to runtime procedures", | ||
| } | ||
|
|
||
| var ProcedureListCommand = &cobra.Command{ |
Contributor
Author
There was a problem hiding this comment.
also here, split up commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification