Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
leggetter
approved these changes
Oct 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a race where a publish can start after
Closehas returned.BasePublisher.StartPublishchecksclosedand then callsactive.Add(1).StartClosesetsclosedand then callsactive.Wait(). The check and theAddaren't one step, so aClosecan land between them:Waitreturns with the counter at 0, the provider closes its client, and the publish goes ahead on the closed client. The race detector reports this asAddconcurrent withWait, andTestClosePublisherDuringConcurrentPublishfails on it now and then under-race.Outside tests, it needs the registry to evict a cached publisher in the short window between resolving it and starting the publish, so it is rare. When it does happen, the publish errors and the message is retried.
The check and the
Addnow run under a read lock, and settingclosedtakes the write lock. A publish either registers beforeClosestarts waiting, or seesclosedand returnsErrPublisherClosed.Waitstays outside the lock, so in-flight publishes still finish.Stress-tested under
-race: fails on main, passes with this change.🤖 Generated with Claude Code