Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Destinations can carry an expiry time. Once it passes, the destination gets no more events, and it gives up its slot under the tenant's destination limit. Nothing sets the field yet: it isn't in the API, and nothing in the codebase writes it. It's groundwork for destination types that only live for a set time; with the field unset, behavior is the same as today.
An expired destination is handled like a disabled one, without being marked disabled:
Destination.ExpiresAtis stored in the Redis and in-memory tenant stores; Redis also keeps it in the per-tenant summary used for event matching. Records without the field read as not expired.Destination.MatchEvent(used by the in-memory store) and the Redis store's summary scan.destination_expired.expires_atin a script, so a destination whose expiry was moved later between the read and the delete is kept.Other improvements:
🤖 Generated with Claude Code