Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Destination URLs come from tenants, and Outpost stores the response body on each attempt. A tenant can point a webhook at the operator's internal network (cloud metadata endpoints, admin services, databases on private IPs) and read what comes back. This adds a switch that keeps webhooks on public addresses. Off by default, since many deployments deliver to services on their own network.
With
DESTINATIONS_WEBHOOK_BLOCK_PRIVATE_ADDRESSES=true, a webhook only connects to publicly routable addresses or to IPs and ranges listed inDESTINATIONS_PRIVATE_ADDRESS_ALLOWLIST. The check runs on the socket right before each connect, against the address actually being dialed, so a DNS answer that changes after creation (DNS rebinding) is still caught. Create and update check the URL as well and reject it early.internal/netguardpackage (standard library only): the IANA special-purpose address ranges, an allowlist of IPs/CIDRs,CheckURLfor a pre-flight check, and aDialContext(a standardnet.Dialer) whoseControlhook refuses any address that isn't allowed. Addresses embedded in IPv4-mapped, NAT64 and 6to4 IPv6 forms are judged by the IPv4 address inside.destregistry.HTTPClientConfiggets aGuardoption. Without a forward proxy, every connection goes through the guard andHTTP_PROXY/HTTPS_PROXYare ignored. With a forward proxy, the proxy's own address isn't checked; the target URL is checked before each request.config.url must resolve to a public address), including when it doesn't resolve. A refused delivery is a failed attempt with codeaddress_not_allowed, retried like any other failure.Notes:
/0, host bits set) fails startup, also while blocking is off.Docs: two config table rows.
🤖 Generated with Claude Code