Repository navigation
Fix frontend bugs found in the code-quality review - #839
Merged
Merged
Conversation
- Submissions dashboard pages each status by offset (k-way merge for "all") instead of growing `limit`, which the API rejects above 500. - Add the missing hf_artifacts and organizations edit-type filters. - Signed-out Save goes through the Saved Papers login (auth origin) and resumes the save; logout resets cached user data. - Saved papers prioritise only the first thumbnails on the page. - Admin placeholder and autonomous-operations styles load on direct visits. - Remove the unused localStorage admin-token header from the API transport. - Confirm task edits only after the server accepts them. - One useInfiniteScroll hook replaces eight sentinel effects, so every feed keeps loading after a filter change leaves the sentinel visible. - SubmitView invalidates every paper feed family. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the concrete bugs (section A) from the 2026-10-30 frontend code-quality review. Frontend only; no API or route contract changes.
Fixes
limitby 25 and refetched from offset 0; the API capslimitat 500. It is now auseInfiniteQuerywith 25-row pages per status. For "all", it merges the next page of every status and advances each status offset by the rows it contributed, so ordering stays exact. Refetches recompute offsets from fresh pages.hf_artifactsandorganizations.apiUrlinstead ofauthUrl. It now uses the existing Saved Papers authorization flow, which also resumes the save after login.AuthProvidernow resets queries when the user goes from signed in to signed out, including on stale-auth events.rank={1}to every card, so every thumbnail loaded eagerly with high priority. Cards now get page-wide positions.submission-loading/submission-empty(used by the App route gates) moved tostyles/features/admin.css.AutonomousOperationsimports the cron stylesheet it uses.cronAdminTokenlocalStorage key, yet the transport would send it asX-Admin-Token. Agent and CLIX-Admin-Tokenusage via curl is unaffected.onMutate, before the server answered. The toast now appears inonSuccess; the optimistic update and rollback are unchanged.AuthorDetailViewhad the fix. A newuseInfiniteScrollhook replaces 8 copied sentinel effects and theirexhaustive-depssuppressions.invalidatePaperFeeds.Validation
npx tsc -p tsconfig.app.json --noEmit: clean.npx eslint src: 0 errors. The 17 warnings are all pre-existingreact-refreshwarnings.npx vitest run: 938 passed, 2 failed. Both failures are inBenchmarkDetailView.test.tsxand fail identically on unmodifiedorigin/main18a9d2a.limitat 25 and advances per-status offsets (pending 13, approved 12, rejected 0).🤖 Generated with Claude Code
Note
Medium Risk
Changes auth redirects, query cache lifecycle on logout, and admin submissions pagination logic; admin token header removal is intentional but touches request transport behavior.
Overview
Fixes several frontend bugs from the code-quality review: submissions “Load more”, auth/bookmark UX, feed scrolling, and admin styling/security cleanup.
The submissions dashboard no longer grows
limituntil the API cap breaks pagination; it usesuseInfiniteQuerywith fixed 25-row pages and per-status offsets when viewing all statuses (merged newest-first). Edit-type filters now includehf_artifactsandorganizations, with a regression test for offset behavior.Signed-out Save routes through the existing Saved Papers authorization flow (and resumes the bookmark after login) instead of building login URLs with
apiUrl.AuthProviderresetQuerieswhen the session ends so bookmark/follow caches don’t linger after logout or stale-auth events.Paper feeds share a new
useInfiniteScrollhook so filter changes that leave the sentinel visible still fetch the next page (replacing eight duplicated effects). Saved papers cards get page-widerankso thumbnails aren’t all high-priority. Edit tasks shows the success toast only after the server confirms; Submit invalidates feeds viainvalidatePaperFeeds.Admin loading/empty placeholders move to shared
admin.css(fixes unstyled direct loads); Autonomous Operations pulls in its cron stylesheet. The deadX-Admin-TokenlocalStorage path is removed fromApiTransport.Reviewed by Cursor Bugbot for commit fb6c9a0. Bugbot is set up for automated code reviews on this repo. Configure here.