Rider Categories Merging - #668
Open
binh-dam-ibigroup wants to merge 11 commits into
Open
Conversation
br648
approved these changes
Sep 7, 2026
br648
left a comment
br648
left a comment
Contributor
There was a problem hiding this comment.
One minor comment. Tests all pass. All good.
| .filter(f -> containsField(allFields, f.name)) | ||
| .collect(Collectors.toList()); | ||
| if (table == Table.RIDER_CATEGORIES) { | ||
| sharedSpecFields = List.copyOf(allFields); |
Contributor
There was a problem hiding this comment.
This would benefit from a comment explaining why it is different from all other tables.
…s, improve comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
devbefore they can be merged tomaster)Description
This PR attempts to resolve merging of the rider_categories.txt, whether it is from the Fares V2 spec or the GTFS+ spec. The minimal set of fields found in rider_categories.txt from the feed versions to merge will be used, and values merged, regardless of whether rider_categories.txt is from GTFS+ or Fares V2. (Merging of whole Fares V2 feeds is out of scope).