Repository navigation
Add altitudeOffset value to renderSurfaces - #217
Merged
Merged
Conversation
pyrollo
force-pushed
the
pyr/surface-offset
branch
from
October 28, 2026 16:15
b2e46fe to
5994532
Compare
[Maven Build Status]📑 Commit: 📦 Download artifact: voxatile.jar |
pyrollo
changed the title
pyrollo
force-pushed
the
pyr/surface-offset
branch
2 times, most recently
from
October 28, 2026 16:25
c1ceea9 to
9d5027d
Compare
pyrollo
marked this pull request as ready for review
October 28, 2026 16:25
indyteo
reviewed
Oct 28, 2026
indyteo
left a comment
indyteo
left a comment
Member
There was a problem hiding this comment.
Some remarks with the Conventional Comments style
Member
|
thought: With parameterized voxelizers (#199), this could be an offset voxelizer to offset coordinates returned by another voxelizer by any X/Y/Z (model/contextual) value |
pyrollo
force-pushed
the
pyr/surface-offset
branch
2 times, most recently
from
November 4, 2026 14:54
851c226 to
d4c3b09
Compare
…f renderBuildings task
pyrollo
force-pushed
the
pyr/surface-offset
branch
2 times, most recently
from
November 4, 2026 15:14
ca781af to
aa5f960
Compare
indyteo
reviewed
Nov 4, 2026
pyrollo
force-pushed
the
pyr/surface-offset
branch
from
November 4, 2026 16:50
aa5f960 to
d975c57
Compare
indyteo
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
altitudelOffsetfield torenderSurfacesrenderBuildingtask (became useless with facades + previous update)ModelValuesinrenderFacadesTaskFeature description
This PR adds a new
altitudelOffsetmodel value field torenderSurfacetask and makesheightmapfield optional.If only
altitudelOffsetis present, surface voxels are placed at this altitude.If only
heightmapis present, surface voxels are placed on heightmap altitude (former behavior).If both
altitudelOffsetandheightmapare present, voxel altitude is the result of addition of both values.This will change again once contextual model values developed.
I also had to update
renderFacadesTaskto make it useModelValuesin order do fix a slight gap between walls and roofs positions.As side effect:
Closes #219
Reason
Old
renderBuildingtask was used only because that feature was missing torenderSurface. WithrenderFacadeit was not understandable to keep it.This feature is simple and enables some interesting possibilities while waiting for contextual values.Self-checks
Complex / Unexpected code is explained / justified with a small comment/docsfolder has been updatedexamples/work the same (or have been adapted if subject to changes in this PR)