fix: treat negative SetTimeout as zero (no timeout)#509
Closed
sonnemusk wants to merge 1 commit into
Closed
Conversation
http.Client documents zero as no timeout; a negative duration is undefined and can cause surprising deadline behavior. Clamp below zero to zero.
Author
|
Closing after a second quality pass: too thin / low user impact. Prefer fewer high-signal fixes. Sorry for the noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetTimeout(-1)stored a negative duration on the underlyinghttp.Client. Zero already means "no timeout"; negative is undefined.Clamp values below zero to zero.
Test plan