Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 238 249 +11
Branches 100 102 +2
=========================================
+ Hits 238 249 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bardrop
force-pushed
the
fix-dataview-contents
branch
from
November 12, 2026 06:06
9e64fa5 to
3b2dd37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112.
DataViewhad no branch inobjEquiv, so two views fell through to the own-keys check. A view has no own keys, so any twoDataViews were equal, in loose and strict mode:assert.deepEqual/assert.deepStrictEqualsay both of these are not equal.The fix follows the
ArrayBufferbranch: brand-check both sides withis-data-view, then compare the bytes each view covers (buffer,byteOffset,byteLength, viadata-view-buffer/data-view-byte-offset/data-view-byte-length) as aUint8Array. Unlike theArrayBufferbranch it doesn't returntrueearly, so own keys are still compared after the bytes, which matches node (a view with an extra own property is not equal).I checked each new case against node 24's
assert.deepEqualandassert.deepStrictEqual:DataViewvs{}taggedDataView: not equal14 of the new assertions fail on
mainand all 792 pass with the change.npm run lintis clean; I bumped the inlinemax-statements/max-lineslimits inobjEquivfor the 4 new statements, and addedDataViewto the eslint globals.