Skip to content

Otlp exporter - #523

Merged
arjun-rajappa merged 38 commits into
masterfrom
otlp-exporter
Aug 14, 2026
Merged

Otlp exporter#523
arjun-rajappa merged 38 commits into
masterfrom
otlp-exporter

Conversation

@arjun-rajappa

Copy link
Copy Markdown
Contributor

No description provided.

@arjun-rajappa arjun-rajappa self-assigned this Aug 13, 2026

@pvital pvital left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few requests.
Please take a look at the issues reported by SonarQube.

Comment thread lib/instana/backend/host_agent_reporting_observer.rb Outdated
Comment thread lib/instana/backend/host_agent_reporting_observer.rb Outdated
Comment thread lib/instana/exporter/otlp/background_job_converter.rb Outdated
@sonarqubecloud

Copy link
Copy Markdown

@pvital pvital left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
…truct

Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
- Add OTLP config block to Config#initialize with defaults (disabled)
- Support config precedence: YAML > env vars > agent discovery > defaults
- Add read_otlp_config_from_agent to apply agent-pushed OTLP settings
- Replace hardcoded INSTANA_OTLP_ENABLED env-var branch in
  HostAgentReportingObserver with initialize_otlp_exporter driven by
  ::Instana.config[:otlp]
- Remove debug info log of converted spans before OTLP export
- Add tests for config and observer initialization

Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
- Introduce SpanDataWithEvents wrapper to carry OTel span events without
  breaking the existing SpanData keyword_init constructor
- Add build_error_events: emits exception event (with stacktrace) or
  error event when span.ec > 0
- Add convert_stack_trace: maps Instana stack frames (c/n/m) to OTel
  exception.stacktrace newline-separated string
- Refactor convert_status → build_status(error_count, error_msg) to
  decouple status from implicit span state
- Implement extract_error_message: searches span[:data][type][:error],
  truncates to 1024 chars per OTel recommendation
- Fix span_name for custom (SDK) spans: read span[:data][:sdk][:name]
  instead of span[:n]
- Extend base_converter_test with coverage for all new paths

Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
…onverters

Each converter now implements a type-specific span_name that follows the
OTel semantic naming conventions instead of returning the raw span[:n] key.

Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
…rs and mark HTTP 4xx EXIT spans as ERROR

Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
…nge:key:queue) with consumer deduplication

Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
@arjun-rajappa
arjun-rajappa enabled auto-merge (rebase) August 14, 2026 13:16
@arjun-rajappa
arjun-rajappa merged commit 2cdacf0 into master Aug 14, 2026
38 of 68 checks passed
@arjun-rajappa
arjun-rajappa deleted the otlp-exporter branch August 14, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants