Clarify that <div> still suppresses the translated-reply webhook topic - #654
Merged
cathalging merged 1 commit intoSep 2, 2026
Merged
Conversation
The caveat added in #638 says the translated-reply webhook topic is suppressed when body has text outside an HTML block element, which invites reaching for <div> — not in the admin sanitizer allowlist, so it's stripped on save and the topic stays suppressed anyway.
markdennis22
approved these changes
Sep 2, 2026
cathalging
deleted the
cathal/openapi-translated-topic-div-clarification
branch
September 2, 2026 14:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
A caveat added in #638 says this webhook topic is suppressed when the reply's
bodyhas text outside an HTML block element. An automated review on the companion developer-docs pull request flagged that this reads as an invitation to wrap that text in a<div>— but<div>isn't one of the HTML elements the admin reply content sanitizer allows, so it's stripped when the reply saves, leaving the text bare and the topic still suppressed. This sentence closes that trap before a developer hits it.How?
Appends the same clarifying sentence to the three admin-reply
translationsfield descriptions in the Preview spec; prose only, no schema or behavior change. A matching update is going into intercom/developer-docs#1133.Generated with Claude Code