Repository navigation
ion-router-outlet OnPush #1758
Description
Original issue by @Abrissirba on 2020-11-06T14:18:32Z
Documentation
Is there any documentation on why you should not use OnPush on components that use ion-router-outlet? It is mentioned here, https://ionicframework.com/docs/angular/lifecycle, but I would like to know about why.
Is it only the component that contains the that shouldn't have OnPush or does it also apply to components that are loaded into the ?
Activity
averyrousseau commentedon Jan 23, 2023
Thank you for the issue. It looks like the docs have since been updated to include more details about this: https://ionicframework.com/docs/angular/lifecycle#angular-life-cycle-events I'm going to close this out, but please feel free to open a new issue if you're still having trouble.
ms-emp commentedon Jun 21, 2023
Is it still relevant that we shouldn't use OnPush?
jbgtmartin commentedon Sep 2, 2026
In https://ionicframework.com/docs/angular/lifecycle, is the section about avoiding
OnPushforion-navorion-router-outletstill relevant, now that Ionic 9 supports zoneless change detection?ShaneK commentedon Sep 2, 2026
Yeah, mostly. On Zone.js it still applies because a clean
OnPushview stops the tick, so a page inside your outlet won't re-render when you mutate a plain field after anawait. We hit that in v9 when Angular 22'sOnPushbecame the default onion-router-outletandion-tabs(which we had to fix for ionic-team/ionic-framework#31406), so both are pinned toDefaultnow. Zoneless is fine, since marking a view for check walksOnPushancestors anyway.The
ngOnInitbit is just out of date, in both modes.jbgtmartin commentedon Sep 2, 2026
Ok, so if I understand correctly, the issue applies to plain properties updates. If all my components inside
<ion-router-outlet>already use signals andOnPushit's safe to switch toOnPushon the component that hosts the<ion-router-outlet>?ShaneK commentedon Sep 2, 2026
@jbgtmartin Yes, that's correct. I have a PR up here that I was making for related changes but went ahead and cleaned up the lifecycle phrasing for it: #4694
jbgtmartin commentedon Sep 2, 2026
Thank you for the explanations here and in the PR, very clear :)