refactor(icons): update the Ionic theme to use Phosphor font icons - #31096
Closed
OS-susmitabhowmik wants to merge 8 commits into
Closed
refactor(icons): update the Ionic theme to use Phosphor font icons#31096OS-susmitabhowmik wants to merge 8 commits into
OS-susmitabhowmik wants to merge 8 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
OS-susmitabhowmik
changed the title
2 tasks
Member
|
I think we can close this in favor of #31284. I can give you co-author there though. Send me a message if you want me to go over any of it! |
Author
Thanks for flagging this @brandyscarney! I'll close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
Currently the ionic theme is using SVG icons
What is the new behavior?
This PR is a proof of concept for updating icons in the ionic theme to use font icons rather than SVGs.
Does this introduce a breaking change?
Other information