fix(input-otp): sync value when length changes - #31485
Open
hemanth004 wants to merge 4 commits into
Open
hemanth004 wants to merge 4 commits into
hemanth004 wants to merge 4 commits into
Conversation
|
@hemanth004 is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
Hey @hemanth004 ! Thanks for your pull request and bug report! I've updated your PR with some fixes - the initial wouldn't have built, but also I think there's a few things in the scope of this fix that also needed to be addressed. Everything in this PR should work now, but it'll need to be reviewed by another member of the team before we can merge it, then the fix will go out in the next patch release after that. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31484
What is the current behavior?
Changing the length prop at runtime updates the rendered input boxes but can leave the public value longer than the rendered inputs.
What is the new behavior?
The component now reinitializes its values and tab indexes when length changes, keeping the public value synchronized with the rendered inputs.
Does this introduce a breaking change?
Other information
Fixes #31484. No dependency updates or breaking API changes.