Private files setup - #401
Open
rimi-itk wants to merge 2 commits into
Open
Conversation
rimi-itk
force-pushed
the
hotfix/private-files
branch
from
August 19, 2026 10:22
3a65ba4 to
97629f0
Compare
rimi-itk
marked this pull request as ready for review
August 19, 2026 10:25
turegjorup
approved these changes
Aug 19, 2026
martinyde
approved these changes
Aug 20, 2026
rimi-itk
commented
Aug 20, 2026
| phpfpm: | ||
| volumes: | ||
| - ../../shared/${SUB_SITE_FOLDER}:/app/web/sites/${SUB_SITE_FOLDER} | ||
| - ../../shared/private-files:/app/private-files |
Author
There was a problem hiding this comment.
Should this be
Suggested change
| - ../../shared/private-files:/app/private-files | |
| - ../../shared/${SUB_SITE_FOLDER}/private-files:/app/private-files |
?
There was a problem hiding this comment.
I don't know enough about how Drupal manages private files to answer authoritatively, but I would think (hope) Drupal can handle both.
But server side it would probably be an advantage to have the files clearly scoped by sub site in the filesystem. For cleanup, backup and monitoring disk usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to ticket
https://leantime.itkdev.dk/_#/tickets/showTicket/8147
Description
Adds private files setup.
Important
We must manually create the
…/shared/private-filesdirectory before deploying this.