Pass JF platform info to Xray Plugin#789
Open
attiasas wants to merge 4 commits into
Open
Conversation
attiasas
added
ignore for release
github-actions
Bot
removed
the
safe to test
attiasas
added
the
safe to test
github-actions
Bot
removed
the
safe to test
attiasas
added
the
safe to test
github-actions
Bot
removed
the
safe to test
| func ToCommandEnvVars(envVarsMap map[string]string) (converted []string) { | ||
| converted = make([]string, 0, len(envVarsMap)) | ||
| for key, value := range envVarsMap { | ||
| // func ToCommandEnvVars(envVarsMap map[string]string) (converted []string) { |
| func (sbg *XrayLibBomGenerator) getPluginEnvVars() utils.EnvironmentVariables { | ||
| envVars := utils.EnvironmentVariables{} | ||
| if sbg.ServerDetails != nil { | ||
| envVars[plugin.XrayUrlEnvVariable] = sbg.ServerDetails.XrayUrl |
Contributor
There was a problem hiding this comment.
are you sure we have sbg.ServerDetails.XrayUrl filled at this point? for local audit we have it as when configuring new JPD it is completed automatically, but what about frogbot that gets only JF_URL
| bom.GenerateSbomForTarget(params.BomGenerator().WithOptions( | ||
| buildinfo.WithDescriptors(targetResult.GetDescriptors()), | ||
| xrayplugin.WithSnippetDetection(shouldIncludeSnippetDetection(params)), | ||
| xrayplugin.WithServerDetails(params.serverDetails), |
Contributor
There was a problem hiding this comment.
use params.ServerDetails()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devbranch.go vet ./....go fmt ./....Following the request of the plugin team to start passing JFROG platform info to the command: