Repository navigation
Fix EXIF orientation - #179
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #169
Photos shot on phones are often stored as landscape pixels plus an EXIF Orientation tag, which nothing in the pipeline honored: the transformers computed their dimensions on the stored pixels, and the processors and post-processors dropping the metadata (
cwebp,jpegoptim,mozjpeg, etc.) produced variations displayed on their side. A newAutoOrientPreProcessor, built on Imagine and registered by default right after the HEIF conversion, now rotates the pixels once and resets the tag, and the pixel dimensions reported for the originals account for the orientation.Also, the
HeifPreProcessornow really produces a JPEG intermediate binary instead of a PNG labelled as JPEG, and the EXIF stripping listener of the demo keeps the orientation tag.