fix: extraction rule executions route to mapping execution pages - #6718
Open
Prabal864 wants to merge 1 commit into
Open
fix: extraction rule executions route to mapping execution pages#6718Prabal864 wants to merge 1 commit into
Prabal864 wants to merge 1 commit into
Conversation
dosubot
Bot
added
the
size:S
|
|
ExecutionsTable hard-coded /mapping/ in its row click handler, so clicking an execution row on the extraction executions page opened the mapping execution detail page instead. The extraction detail page also omitted type: "extraction" when calling useEnrichmentEvent, so even a direct visit fetched /mapping/... data. Add a basePath prop to ExecutionsTable (default mapping, preserving existing behavior) and pass it from the extraction executions page. Pass type: "extraction" explicitly from the extraction detail page. Fixes keephq#6703
Prabal864
force-pushed
the
fix/extraction-execution-routing
branch
from
August 21, 2026 20:57
d6d7ab4 to
f424a0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #6703.
Clicking an execution row on the extraction rule executions page opened the mapping rule execution detail page instead. Even navigating directly to the extraction execution URL fetched mapping data.
Root cause
ExecutionsTable's row click handler hard-coded/mapping/${row.rule_id}/executions/${row.id}, with no way for a caller to route elsewhere.useEnrichmentEvent({ ruleId, executionId })withouttype: "extraction", and that hook defaultstypeto"mapping", so it hit the/mapping/...API endpoint regardless of the URL.Fix
basePathprop toExecutionsTable("mapping" | "extraction", defaults to"mapping"so the existing mapping pages are unaffected) and used it in the row-click navigation instead of the hard-coded path.basePath="extraction"from the extraction executions list page.type: "extraction"explicitly from the extraction execution detail page so it fetches from the correct endpoint.Testing
components/table/__tests__/ExecutionsTable.test.tsxcovering both the default (mapping) andbasePath="extraction"row-click routing.npx jest— full suite: 52 suites / 468 tests pass.npx eslinton all changed files — clean.npx tsc --noEmit— no new errors (18 pre-existing errors onmain, unrelated to these files, unchanged).