feat(developer): reviewRules: return object instead of string[] 😎#16073
Open
SabineSIL wants to merge 9 commits into
Open
feat(developer): reviewRules: return object instead of string[] 😎#16073SabineSIL wants to merge 9 commits into
SabineSIL wants to merge 9 commits into
Conversation
User Test ResultsTest specification and instructions User tests are not required |
keymanapp-test-bot
Bot
changed the title
SabineSIL
changed the title
…vert-warningMessages
…vert-warningMessages
…github.com/keymanapp/keyman into feat/developer/kmc-convert-warningMessages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
during review of PR12564 we decided to refactor ReviewRules() so that it returns an interface instead of an string[]
see comment here
@keymanapp-test-bot skip
see also: