fix(android): add permissions for Sentry and set default keyboard - #16216
Merged
Conversation
This change fixes two problems that cause a script error in Sample1 app: - add internet access permissions so that the Sentry server can be reached - explicitly set the default keyboard since sil_euro_latin keyboard is not included in the sample apps. This works around #16215. Fixes: #16180 Build-bot: release:android
keymanapp-test-bot
Bot
added
the
user-test-missing
User Test ResultsTest specification and instructions
Test Artifacts |
mcdurdin
approved these changes
Jul 10, 2026
Member
There was a problem hiding this comment.
LGTM. I think we should note setDefaultKeyboard as a known issue in the release notes:
keymanapp-test-bot
Bot
added
has-user-test
user-test-required
Member
Test ResultsGROUP_SAMPLE1:
GROUP_SAMPLE2:
|
keymanapp-test-bot
Bot
removed
the
user-test-required
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.256-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes two problems that cause a script error in the sample apps:
Fixes: #16180
Build-bot: release:android
User Testing
GROUP_SAMPLE1
GROUP_SAMPLE2
TEST_SAMPLE: