Fix LeaderElector waiting a full extra lease duration before acquiring an already-expired lease on startup

[Copilot]

On first observing an existing lock record, LeaderElector stamped its internal observedTimeMilliSeconds with the current wall-clock time rather than the record's actual renewTime. This made a freshly-started candidate treat an already-expired lease as still valid for one more full leaseDuration, delaying takeover instead of acquiring it immediately.

• LeaderElector.tryAcquireOrRenew: when the observed record is being set for the very first time (no prior observedRecord), initialize observedTimeMilliSeconds from the record's own renewTime instead of System.currentTimeMillis(). Subsequent observations during normal operation still use the current time, preserving the existing clock-skew tolerance.
• Test: added acquiresAlreadyExpiredLeaseImmediately in LeaderElectorTest, which seeds a lock with a record whose renewTime is well past leaseDuration and asserts a new candidate acquires leadership promptly rather than waiting out an extra lease period.

if (!oldLeaderElectionRecord.equals(this.observedRecord)) {
  boolean firstObservation = this.observedRecord == null;
  this.observedRecord = oldLeaderElectionRecord;
  this.observedTimeMilliSeconds =
      firstObservation
          ? oldLeaderElectionRecord.getRenewTime().getTime()
          : System.currentTimeMillis();
}

• Fixes LeaderElector fails to acquire expired lease on initial run due to missing expiration check #4913

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: brendandburns / name: brendandburns (ad828d3)

[brendandburns]

/lgtm
/approve

[brendandburns]

/lgtm
/approve

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, Copilot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment