Skip to content

Not generated code: clean up python 2.7 support artefacts#2570

Open
penguinolog wants to merge 2 commits into
kubernetes-client:masterfrom
penguinolog:clean-up_kubernetes_base
Open

Not generated code: clean up python 2.7 support artefacts#2570
penguinolog wants to merge 2 commits into
kubernetes-client:masterfrom
penguinolog:clean-up_kubernetes_base

Conversation

@penguinolog
Copy link
Copy Markdown

@penguinolog penguinolog commented May 11, 2026

  • drop six dependency
  • do not subclass object
  • drop from __future__ import print_function
  • drop # -*- coding: utf-8 -*- comments

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Python 2.7 reached EOL > 6 years ago, cleaning-up will simplify maintenance and eventually reduce dependency tree.

Which issue(s) this PR fixes:

#2535

Special notes for your reviewer:

Does this PR introduce a user-facing change?

No user-facing changes

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 11, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 11, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 11, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: penguinolog
Once this PR has been reviewed and has the lgtm label, please assign yliaog for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 11, 2026

Welcome @penguinolog!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@penguinolog penguinolog changed the title Not generated code: clean up python 3.7 support artefacts Not generated code: clean up python 2.7 support artefacts May 11, 2026
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 11, 2026
@k8s-ci-robot k8s-ci-robot requested review from fabianvf and roycaihw May 11, 2026 12:35
@penguinolog penguinolog force-pushed the clean-up_kubernetes_base branch from b3ad4bf to 1e841cb Compare May 11, 2026 12:35
@penguinolog
Not generated code: clean up python 2.7 support artefacts
eb21437 
* drop `six` dependency
* do not subclass `object`
* drop `from __future__ import print_function`
* drop `# -*- coding: utf-8 -*-` comments
@penguinolog penguinolog force-pushed the clean-up_kubernetes_base branch from 1e841cb to eb21437 Compare May 11, 2026 12:39
@penguinolog
Force apply autopep8
1ee5c80 
As required by contributing documentation
@penguinolog penguinolog force-pushed the clean-up_kubernetes_base branch from 633b59f to 1ee5c80 Compare May 11, 2026 12:47
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 11, 2026
@penguinolog
Copy link
Copy Markdown
Author

penguinolog commented May 11, 2026

I feel "autopep8" part is not really critical (100% generated change). Should I create "related" PR instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabianvf fabianvf Awaiting requested review from fabianvf

@roycaihw roycaihw Awaiting requested review from roycaihw

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@penguinolog @k8s-ci-robot