fix: join group routes without leading slash - #3104
Closed
Rayan-and-beyond wants to merge 1 commit into
Closed
Rayan-and-beyond wants to merge 1 commit into
Rayan-and-beyond wants to merge 1 commit into
Conversation
Signed-off-by: Rayan-and-beyond <263488867+Rayan-and-beyond@users.noreply.github.com>
Contributor
|
group (prefix) does not necessarly need to mean segment in url that ends with slash. |
Author
|
That makes sense — the prefix can be an intentional partial path rather than a segment boundary, so inserting a slash would change valid routing semantics. I’ll close this rather than force that behavior. Thanks for clarifying. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3099
Group routes now insert the missing separator when a group prefix and route path meet without
/. Existing routes that already include the separator keep their current behavior.Validation:
/v1postsand 404git diff --check