fix(job): supervise scheduled manual runs on host - #190
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ob job run --detachfor durable acceptance without waitingDesign
This reuses the scheduled-job runner rather than introducing a daemon, helper binary, detached Docker path, or second state store. The unit remains the authority for timeout, retries, overlap protection, container cleanup, logs, and run history.
Before submission, Onebox stages the approved release and runtime digest. The installed runner validates both after acquiring its host locks and before starting the container. Older installed runners are refused with
ob schedule applyguidance.Foreground mode follows the systemd unit and reports its host-recorded outcome. Ctrl-C stops following but does not cancel the unit.
--detachreturns aftersystemctl start --no-blockaccepts the activation and prints the operation ID plus the existing history command.The loader change stays inside
internal/ui: TTYs get animation plus elapsed time; pipes and CI retain plain start/completion lines; structured output remains untouched.Verification
just checkjust server-e2e— passed against a disposable Lima VM with real SSH, systemd, and Docker (662.721s)Closes #189