fix(postgres): enable whoami/std feature#4275
Open
svnrb wants to merge 1 commit into
Open
Conversation
Commit 1dd526a bumped whoami to v2, but it seems that version now needs to have the `std` feature enabled to do anything useful. In earlier sqlx versions, connection strings like `postgresql:///dbname` correctly used the current user's name, matching psql's behavior. Now, it falls back to `anonymous`. Enabling the `std` feature fixes that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 1dd526a bumped whoami to v2, but it seems that version now needs to have the
stdfeature enabled to do anything useful.In earlier sqlx versions, connection strings like
postgresql:///dbnamecorrectly used the current user's name, matching psql's behavior. Now, it falls back toanonymous. Enabling thestdfeature fixes that.Does your PR solve an issue?
Yes, but I don't think it's been reported on GitHub yet.
Is this a breaking change?
Unlikely; it does of course change behavior but I'd classify it as a bug fix.