chore: update launchdarkly-android-client-sdk to 5.14.0 and appcompat to 1.8.0 - #18
Merged
Merged
Conversation
Also bumps the Gradle wrapper to 8.14.5 (latest 8.x). Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
@cursor review |
kinyoklion
approved these changes
Aug 24, 2026
kinyoklion
marked this pull request as ready for review
August 24, 2026 20:47
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
tanderson-ld
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Routine dependency refresh for this example. All three are exact pins, so they only move when bumped:
com.launchdarkly:launchdarkly-android-client-sdk5.13.3→5.14.0(latest on Maven Central, same major).androidx.appcompat:appcompat1.7.1→1.8.0(latest release; builds fine against the example's existingcompileSdk 34).8.14.3→8.14.5(latest 8.x). AGP (8.13.2) is already latest, so it is untouched.No example source changes: the app's SDK usage (
LDConfig.Builder(AutoEnvAttributes.Enabled),LDClient.init(app, config, context, 5),boolVariation,registerFeatureFlagListener,flush) is all current in 5.14.0, and a--warning-mode allbuild reports zero deprecation warnings.Validated end-to-end on an Android 34 x86_64 emulator with the real hello-apps mobile key and flag key supplied via untracked local edits (never committed):
Implementation details
./gradlew assembleDebug --warning-mode allwith JDK 17 and Android SDK/build-tools 34 —BUILD SUCCESSFUL, no deprecation or other warnings.androidx.appcompat:appcompat:1.8.0resolves cleanly and does not raise the AAR-metadataminCompileSdkrequirement above 34, so nocompileSdk/targetSdkchange is needed. The SDK's own transitiveappcompat:1.1.0is upgraded to 1.8.0 by this pin.adb install+am start, thenuiautomator dump, printedFeature flag 'hello-boolean' is true— the same assertion the repo'srun.ymlworkflow makes.minSdkVersion 24/compileSdk 34are unchanged since nothing requires more.Limitations
Verified on an emulator only, not a physical device.
Link to Devin session: https://app.devin.ai/sessions/3e3852e800fd463393fb8edd22981355
Note
Overview
This PR is a dependency-only refresh for the hello-android-java example—no application source or SDK configuration changes.
app/build.gradlepinsandroidx.appcompat:appcompatfrom 1.7.1 → 1.8.0 andcom.launchdarkly:launchdarkly-android-client-sdkfrom 5.13.3 → 5.14.0 (same major for the SDK).gradle/wrapper/gradle-wrapper.propertiesupdates the wrapper from Gradle 8.14.3 → 8.14.5.compileSdk34,minSdkVersion24, and Java 17 settings are unchanged.Reviewed by Cursor Bugbot for commit 961556f. Bugbot is set up for automated code reviews on this repo. Configure here.