fix: restore the missing-SDK-key guard in index.js - #22
Draft
devin-ai-integration[bot] wants to merge 1 commit into
Draft
fix: restore the missing-SDK-key guard in index.js#22devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Author
|
@cursor review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Routine SDK audit of this example; no version change was needed, but the "please set your SDK key" guard was dead code.
@launchdarkly/node-server-sdkneeds no bump: manifest declares^9.12.1, latest on npm is 9.13.1, and there is no committed lock file, sonpm installalready resolves to latest 9.x.if (!sdkKey)always false:index.jsonly.fix:(notchore:) because it touches shipped example code.init,waitForInitialization({timeout}),variation,on('update:...')are all current; no deprecation warnings undernode --trace-deprecation.Implementation details
Before this change, running
node index.jswithoutLAUNCHDARKLY_SDK_KEYinitialized the SDK with the literal stringyour-sdk-keyand failed with an opaque error, and exited 0 in the CI path:After:
Validation with a real key (hello-apps project, flag
hello-boolean):README needed no change: it already documents
LAUNCHDARKLY_SDK_KEY/LAUNCHDARKLY_FLAG_KEYand mentions no SDK version. Console app, so no screenshots. Diff is 2 insertions / 2 deletions.Link to Devin session: https://app.devin.ai/sessions/3b513691f831464c8b12d98f09d0387f