Skip to content

chore: update dev dependency pins and fix README build instructions - #17

Open
devin-ai-integration[bot] wants to merge 2 commits into
mainfrom
devin/1786352694-update-dev-deps
Open

chore: update dev dependency pins and fix README build instructions#17
devin-ai-integration[bot] wants to merge 2 commits into
mainfrom
devin/1786352694-update-dev-deps

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Refreshes the exact dev-dependency pins to the latest within their current major, and fixes README build instructions that told users to edit a variable that no longer exists.

  • @types/node 22.10.1 → 22.20.1, typescript 5.7.2 → 5.9.3 (exact pins, same major); ts-node already latest (10.9.2).
  • LaunchDarkly SDK constraint left alone: ">= 9.0.0" already resolves to the latest 9.x (9.13.1) and no lock file is committed, so a floor bump would be churn.
  • README step 2 now documents LAUNCHDARKLY_SDK_KEY / LAUNCHDARKLY_FLAG_KEY env vars — index.ts has no editable sdkKey = "1234..." literal anymore; wording matches hello-node-server.
  • Dev-dependency + docs only, hence chore: — no shipped code or user-facing requirement changes.
Implementation details

Verified locally on Node 24.16.0 with the updated pins:

  • npm i@launchdarkly/node-server-sdk@9.13.1, @types/node@22.20.1, typescript@5.9.3; 0 vulnerabilities.
  • npx tsc --noEmit index.ts → clean, no type errors and no deprecation warnings.
  • CI=1 LAUNCHDARKLY_SDK_KEY=… LAUNCHDARKLY_FLAG_KEY=hello-boolean npm start:
info: [LaunchDarkly] Opened LaunchDarkly stream connection
*** SDK successfully initialized!
*** The 'hello-boolean' feature flag evaluates to true.

No deprecated LaunchDarkly SDK APIs are used (init, waitForInitialization({timeout}), variation, on('update:…') are all current). Console app, so no screenshots.

Note: the "Require additional human oversight on bot PRs" check stays red by org policy and needs a human.

Link to Devin session: https://app.devin.ai/sessions/73b046543ab7426180689a07de610afa


Note

Overview
README build steps no longer tell users to edit sdkKey / featureFlagKey in index.ts. Step 2 now documents LAUNCHDARKLY_SDK_KEY and LAUNCHDARKLY_FLAG_KEY (with bash export examples), notes the default flag key sample-feature, and adds what to expect after npm start (evaluation message and live flag updates).

Dev dependencies are bumped on the same majors: @types/node 22.10.1 → 22.20.1 and typescript 5.7.2 → 5.9.3. Runtime dependency on @launchdarkly/node-server-sdk is unchanged.

Reviewed by Cursor Bugbot for commit 258e4b3. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: jbailey@launchdarkly.com <accounts@sidewaysgravity.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration devin-ai-integration Bot changed the title chore: update TypeScript and @types/node dev dependency pins chore: update dev dependency pins and fix README build instructions Aug 24, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

@cursor review

@kinyoklion
kinyoklion marked this pull request as ready for review August 24, 2026 20:48
@kinyoklion
kinyoklion requested a review from a team as a code owner August 24, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants