chore: update dev dependency pins and fix README build instructions - #17
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
chore: update dev dependency pins and fix README build instructions#17devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
Co-Authored-By: jbailey@launchdarkly.com <accounts@sidewaysgravity.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
@cursor review |
kinyoklion
marked this pull request as ready for review
August 24, 2026 20:48
kinyoklion
approved these changes
Aug 24, 2026
jsonbailey
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshes the exact dev-dependency pins to the latest within their current major, and fixes README build instructions that told users to edit a variable that no longer exists.
@types/node22.10.1 → 22.20.1,typescript5.7.2 → 5.9.3 (exact pins, same major);ts-nodealready latest (10.9.2).">= 9.0.0"already resolves to the latest 9.x (9.13.1) and no lock file is committed, so a floor bump would be churn.LAUNCHDARKLY_SDK_KEY/LAUNCHDARKLY_FLAG_KEYenv vars —index.tshas no editablesdkKey = "1234..."literal anymore; wording matches hello-node-server.chore:— no shipped code or user-facing requirement changes.Implementation details
Verified locally on Node 24.16.0 with the updated pins:
npm i→@launchdarkly/node-server-sdk@9.13.1,@types/node@22.20.1,typescript@5.9.3; 0 vulnerabilities.npx tsc --noEmit index.ts→ clean, no type errors and no deprecation warnings.CI=1 LAUNCHDARKLY_SDK_KEY=… LAUNCHDARKLY_FLAG_KEY=hello-boolean npm start:No deprecated LaunchDarkly SDK APIs are used (
init,waitForInitialization({timeout}),variation,on('update:…')are all current). Console app, so no screenshots.Note: the "Require additional human oversight on bot PRs" check stays red by org policy and needs a human.
Link to Devin session: https://app.devin.ai/sessions/73b046543ab7426180689a07de610afa
Note
Overview
README build steps no longer tell users to edit
sdkKey/featureFlagKeyinindex.ts. Step 2 now documentsLAUNCHDARKLY_SDK_KEYandLAUNCHDARKLY_FLAG_KEY(with bashexportexamples), notes the default flag keysample-feature, and adds what to expect afternpm start(evaluation message and live flag updates).Dev dependencies are bumped on the same majors:
@types/node22.10.1 → 22.20.1 andtypescript5.7.2 → 5.9.3. Runtime dependency on@launchdarkly/node-server-sdkis unchanged.Reviewed by Cursor Bugbot for commit 258e4b3. Bugbot is set up for automated code reviews on this repo. Configure here.