chore(node-client-sdk): adding additional option values#1443
Conversation
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
|
@launchdarkly/js-client-sdk-common size report |
|
@launchdarkly/browser size report |
d6151bf to
7cf9558
Compare
|
@cursor review |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a1a635d. Configure here.
a1a635d to
1c852e7
Compare
This PR will add some missed option values:
Note
Medium Risk
Secure Mode
hashchanges which contexts are accepted on stream/poll URLs; behavior is covered by tests but mistakes could block flag delivery for signed contexts.Overview
Adds Secure Mode support on
identifyand wires wrapper SDK metadata through the Node client-side SDK.Per-identify
hash: NewNodeIdentifyOptions(exported asLDIdentifyOptions) adds an optional Secure Mode hash.NodeDataManagerkeeps a_currentHashfrom config or the latest identify (per-identify wins; empty string is ignored), sets thehquery parameter on stream/poll connections, and uses it inmakeRequestor. A lateridentifywithouthashfalls back to the confighashor omitsh. Publicidentifytypings now useNodeIdentifyOptions.Wrapper metadata:
wrapperNameandwrapperVersionare validated in node options, passed fromNodePlatformintoNodeInfo, and included insdkData()when set. Option validation now iteratesNodeOptionskeys so base options with validators are handled consistently.Tests: New
NodeDataManagertests cover hash behavior across streaming, polling, mode switches, bootstrap, and fallback; platform/options tests cover wrapper fields.Reviewed by Cursor Bugbot for commit 44bdaf0. Bugbot is set up for automated code reviews on this repo. Configure here.