Skip to content

chore(node-client-sdk): adding additional option values#1443

Merged
joker23 merged 4 commits into
mainfrom
skz/sdk-2195/node-client-sdk-next-port-client-sdk-config
Jun 16, 2026
Merged

chore(node-client-sdk): adding additional option values#1443
joker23 merged 4 commits into
mainfrom
skz/sdk-2195/node-client-sdk-next-port-client-sdk-config

Conversation

@joker23

@joker23 joker23 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

This PR will add some missed option values:

  • NodeIdentifyOptions extends LDIdentifyOptions with an optional hash field; per-identify hash overrides the config-level hash for that call and all subsequent requests until the next identify
  • NodeInfo accepts wrapperName/wrapperVersion and forwards them to sdkData(); NodePlatform reads these from ValidatedOptions
  • Also adding unit tests for datamanager

Note

Medium Risk
Secure Mode hash changes which contexts are accepted on stream/poll URLs; behavior is covered by tests but mistakes could block flag delivery for signed contexts.

Overview
Adds Secure Mode support on identify and wires wrapper SDK metadata through the Node client-side SDK.

Per-identify hash: New NodeIdentifyOptions (exported as LDIdentifyOptions) adds an optional Secure Mode hash. NodeDataManager keeps a _currentHash from config or the latest identify (per-identify wins; empty string is ignored), sets the h query parameter on stream/poll connections, and uses it in makeRequestor. A later identify without hash falls back to the config hash or omits h. Public identify typings now use NodeIdentifyOptions.

Wrapper metadata: wrapperName and wrapperVersion are validated in node options, passed from NodePlatform into NodeInfo, and included in sdkData() when set. Option validation now iterates NodeOptions keys so base options with validators are handled consistently.

Tests: New NodeDataManager tests cover hash behavior across streaming, polling, mode switches, bootstrap, and fallback; platform/options tests cover wrapper fields.

Reviewed by Cursor Bugbot for commit 44bdaf0. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26365 bytes
Compressed size limit: 29000
Uncompressed size: 129044 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31978 bytes
Compressed size limit: 34000
Uncompressed size: 114243 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 38739 bytes
Compressed size limit: 39000
Uncompressed size: 212244 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179579 bytes
Compressed size limit: 200000
Uncompressed size: 831422 bytes

@joker23 joker23 force-pushed the skz/sdk-2195/node-client-sdk-next-port-client-sdk-config branch from d6151bf to 7cf9558 Compare June 12, 2026 19:33
@joker23

joker23 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

cursor[bot]

This comment was marked as resolved.

@joker23

joker23 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit a1a635d. Configure here.

@joker23 joker23 marked this pull request as ready for review June 12, 2026 20:14
@joker23 joker23 requested a review from a team as a code owner June 12, 2026 20:14
devin-ai-integration[bot]

This comment was marked as resolved.

@joker23 joker23 force-pushed the skz/sdk-2195/node-client-sdk-next-port-client-sdk-config branch from a1a635d to 1c852e7 Compare June 15, 2026 21:23
devin-ai-integration[bot]

This comment was marked as resolved.

@joker23 joker23 merged commit 6091a47 into main Jun 16, 2026
50 checks passed
@joker23 joker23 deleted the skz/sdk-2195/node-client-sdk-next-port-client-sdk-config branch June 16, 2026 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants