Skip to content

fix: remediate high & critical Dependabot and Wiz vulnerabilities#625

Merged
Vadman97 merged 3 commits into
mainfrom
devin/1781296389-remediate-security-alerts
Jun 15, 2026
Merged

fix: remediate high & critical Dependabot and Wiz vulnerabilities#625
Vadman97 merged 3 commits into
mainfrom
devin/1781296389-remediate-security-alerts

Conversation

@pkaeding

@pkaeding pkaeding commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Remediate high & critical security vulnerabilities flagged by Dependabot and Wiz.

Yarn resolutions (critical/high)

Package Severity Vulnerability Resolution
shell-quote Critical Prototype pollution via __proto__ (CVE-2026-46625) ^1.8.4
@grpc/grpc-js High Multiple vulnerabilities (< 1.9.16, < 1.14.4) ~1.9.16 / ^1.14.4
js-cookie High Prototype pollution via __proto__ ^3.0.7

Yarn resolutions bumped (moderate/low)

Package Old New Reason
hono ^4.12.14 ^4.12.21 Multiple moderate CVEs
qs ^6.14.1 ^6.14.2 DoS via arrayLimit bypass
devalue ^5.6.2 ^5.6.4 Prototype pollution + amplification

Ruby e2e apps — puma (high)

Updated puma from ~> 6.x to ~> 7.2 across all three e2e Ruby apps. No 6.x patch exists; first patched version is 7.2.1.

React Native e2e — npm overrides

Added overrides for shell-quote, @remix-run/server-runtime, and tmp in e2e/react-native/package.json. The lockfile uses workspace:* and cannot be regenerated outside the full workspace context. (turbo-stream v3 override was removed since it's wire-format incompatible with @remix-run/server-runtime 2.x.)

How did you test this change?

  • yarn install succeeded with updated resolutions
  • yarn format:all passed
  • bundle update puma succeeded for all three Ruby e2e apps
  • Verified resolved versions in yarn.lock: shell-quote@1.8.4, @grpc/grpc-js@1.9.16 + @grpc/grpc-js@1.14.4, js-cookie@3.0.8, hono@4.12.25, devalue@5.8.1, qs@6.15.2

Are there any deployment considerations?

No. These are dependency version bumps only — no application code changes.

Link to Devin session: https://app.devin.ai/sessions/00fbfec1acf445279796ff45a7b65731
Requested by: @pkaeding


Note

Low Risk
Changes are version pins and lockfile updates in e2e/demo paths; Puma 7 is a major bump but limited to test apps with standard config.

Overview
Bumps transitive and direct dependencies to address Dependabot/Wiz findings, with no application code changes.

Root package.json resolutions add or tighten pins for shell-quote, js-cookie, and @grpc/grpc-js, and bump hono, qs, and devalue; yarn.lock reflects the resolved versions (including consolidated shell-quote entries).

e2e/react-native/package.json adds npm overrides for shell-quote, @remix-run/server-runtime, and tmp.

All three Ruby e2e apps move puma from 6.x to ~> 7.2 (locks resolve to 7.2.1); lockfiles also pick up launchdarkly-observability 0.2.1 where the path gem is used.

Reviewed by Cursor Bugbot for commit f5f47ac. Bugbot is set up for automated code reviews on this repo. Configure here.

Add yarn resolutions to fix:
- shell-quote (critical): prototype pollution via __proto__, patched to ^1.8.4
- @grpc/grpc-js (high): multiple vulnerabilities, patched to ^1.9.16 and ^1.14.4
- js-cookie (high): prototype pollution, patched to ^3.0.7

Bump existing resolutions:
- hono: ^4.12.14 -> ^4.12.21
- qs: ^6.14.1 -> ^6.14.2
- devalue: ^5.6.2 -> ^5.6.4

Update Ruby e2e apps:
- puma: ~> 6.x -> ~> 7.2 (no 6.x patch available, patched at 7.2.1)

Add npm overrides in e2e/react-native/package.json:
- shell-quote, @remix-run/server-runtime, tmp, turbo-stream

Co-Authored-By: Patrick Kaeding <patrick@kaeding.name>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@pkaeding pkaeding requested a review from a team June 12, 2026 21:08
@pkaeding pkaeding marked this pull request as ready for review June 12, 2026 21:08
@pkaeding pkaeding requested a review from a team as a code owner June 12, 2026 21:08

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 927d818. Configure here.

Comment thread package.json
Comment thread e2e/react-native/package.json Outdated
devin-ai-integration Bot and others added 2 commits June 12, 2026 21:11
- @grpc/grpc-js@~1.8.0: use ~1.9.16 instead of ^1.9.16 to stay on the
  1.9.x line and avoid deduping into 1.14.x for google-gax/firebase-admin
- Remove turbo-stream ^3.0.0 override from react-native e2e since v3 is
  wire-format incompatible with @remix-run/server-runtime 2.x

Co-Authored-By: Patrick Kaeding <patrick@kaeding.name>
Co-Authored-By: Patrick Kaeding <patrick@kaeding.name>
@Vadman97 Vadman97 merged commit e13f8b0 into main Jun 15, 2026
31 checks passed
@Vadman97 Vadman97 deleted the devin/1781296389-remediate-security-alerts branch June 15, 2026 14:44
abelonogov-ld added a commit that referenced this pull request Jun 17, 2026
* main:
  chore: release main (#631)
  fix(highlight.run): make published TypeScript declarations resolvable (#629)
  chore: release main (#628)
  fix: remediate high & critical Dependabot and Wiz vulnerabilities (#625)
  feat(flutter): allow overriding OTLP endpoint and backend URL in example (#624)

# Conflicts:
#	sdk/@launchdarkly/flutter/packages/observability/CHANGELOG.md
#	sdk/@launchdarkly/flutter/packages/observability/ios/launchdarkly_flutter_observability.podspec
#	sdk/@launchdarkly/flutter/packages/observability/ios/launchdarkly_flutter_observability/Package.swift
#	sdk/@launchdarkly/flutter/packages/observability/pubspec.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants