fix(runner): avoid stdin backpressure before output readers start - #110
Draft
Haloukaidi wants to merge 1 commit into
Draft
fix(runner): avoid stdin backpressure before output readers start#110Haloukaidi wants to merge 1 commit into
Haloukaidi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompt delivery currently writes synchronously to the child's stdin before stdout/stderr readers and watchdog checks start. A child that emits enough startup output before reading a long prompt can fill both pipe buffers and leave both processes waiting.
Provide the UTF-8 prompt through a seeked temporary file inherited as stdin. The parent does not write into a live child's pipe; newline/EOF behavior and prompt privacy are retained. The temporary parent handle is closed when spawning finishes, including spawn failure. Existing file-based prompt paths use closed input through DEVNULL.
Validation on Windows / Python 3.13:
git diff --checkpassed.Draft pending cross-platform review and CI. This change is independent of Windows descendant ownership and output-reader cleanup.