Conversation
This reverts #1272 as there are too many subtle errors with keeping a flag on the connection: #1299, #1320, and possibly more. When I added this I thought this should be fairly safe to do because it adapted a long-existing mechanism, but it seems I was wrong about that – I guess that was always a bit buggy but no one noticed because it's used fairly infrequently. I find it too complex to follow, and it doesn't really fix anything: it just gives a nicer error message on wrong usage. That's nice, but not critical. Correct behaviour is. So just revert it for now. Can come back to this at some point, but I don't really have the time for it now. Also stop tracking it for COPY, as that wasn't entirely correct either. Fixes #1320 Closes #1321
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #1272 as there are too many subtle errors with keeping a flag on the connection: #1299, #1320, and possibly more. When I added this I thought this should be fairly safe to do because it adapted a long-existing mechanism, but it seems I was wrong about that – I guess that was always a bit buggy but no one noticed because it's used fairly infrequently.
I find it too complex to follow, and it doesn't really fix anything: it just gives a nicer error message on wrong usage. That's nice, but not critical. Correct behaviour is.
So just revert it for now. Can come back to this at some point, but I don't really have the time for it now. Also stop tracking it for COPY, as that wasn't entirely correct either.
Fixes #1320
Closes #1321