Add Polygon/Polyhedron NSIDED/NFACED ExodusII output#4490
Add Polygon/Polyhedron NSIDED/NFACED ExodusII output#4490ConnorOuellette wants to merge 10 commits into
Conversation
roystgnr
left a comment
There was a problem hiding this comment.
I'd have split this into like 6 commits instead of 2 (re-bootstrap should be separate, tests could be separate, additional build_cube option should be separate), but the contents look mostly solid. That hardcoded block id (unless I'm just misunderstanding?) is the only thing that looks wrong.
|
Looks like you turned on some auto-code-reformatting option in your editor? That works within MOOSE, so long as you're pointing clang-format to the MOOSE config file and you're using the right clang-format version, but libMesh doesn't use the same (or any clang-format config-describable) formatting standards, and auto-reformatting utterly wrecked your ff02c5c commit. I can't find the needle of the actual changes in the 4000-line haystack of the reformatting. As a general safety rule, never |
…ged has_c0polyhedron to bool for clarity
…r tetrahedralization
7d9682a to
f1821dd
Compare
roystgnr
left a comment
There was a problem hiding this comment.
The elem quality updates should have gone in a separate PR, but fortunately I'm not seeing any problems with them, so we might as well get them in via this one.
Civet's not letting me activate the jobs here, though; hopefully it's an easy fix, but we'll have to wait on CI before merging.
|
-Wshadow errors ... but the second one actually does look like poor name choice overlap. |
|
Huh. These remaining errors are real, and there's more than one variety of them. I can reproduce some kind of error; I'll try to look into it soon. |
Summary
This adds ExodusII output support for libMesh’s arbitrary polygon and polyhedron elements:
C0POLYGONelements as ExodusNSIDEDblocksC0POLYHEDRONelements as ExodusNFACEDblocksNFACEDoutputNotes