Add a side hierarchic nodal soln implementation#4494
Conversation
Co-authored-by: Codex <codex@openai.com>
|
If we agree on this implementation, I'd probably go and temporarily skip the affected MOOSE tests |
|
This is how
With this PR: CONSTANT SIDE_HIERARCHIC side_var
With this PR: FIRST SIDE_HIERARCHIC aux_side_var
|
There's definitely a lot of room for debate here, and a whole spectrum of possible positions to take from "Roy was being too lazy" on the one end through "Roy was just being thoughtless" on the other, but I'm not sure I want to actually find out which one of those positions wins, and I am sure I like your solution here better. |
roystgnr
left a comment
There was a problem hiding this comment.
Let's skip the affected tests and run CI again to be paranoid before merging; I just finally fixed that stupid openmp bug and I'm already getting used to seeing everything green again.


Given the previous comment here (which I've temporarily kept), I anticipate some debate on this, although I think the implementation is defensible given what we already do for projecting discontinuous solutions onto nodes for other output cases