Skip to content

added pt locale - #1017

Open
paulocoutinhox wants to merge 3 commits into
libredb:mainfrom
paulocoutinhox:pt-locale
Open

paulocoutinhox wants to merge 3 commits into
libredb:mainfrom
paulocoutinhox:pt-locale

Conversation

@paulocoutinhox

Copy link
Copy Markdown

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test addition or update

Related Issue

Closes #

Changes Made

  • added readme in pt language

Testing

  • I have tested this locally
  • I have added/updated tests
  • All existing tests pass

Test Environment

  • LibreDB Studio Version:
  • Browser:
  • OS:
  • Node.js/Bun Version:
  • Database Type:

Screenshots (if applicable)

Checklist

  • My code follows the project's code style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The required CI test job passes the 100% line-coverage gate (bun run test:coverage and bun run coverage:check)
  • If I changed src/lib/db/providers/, I updated the matching docs/providers/ documentation and tests/integration/db/ tests in the same PR (provider triad)
  • Any dependent changes have been merged and published

Additional Notes

@cevheri

cevheri commented Sep 20, 2026

Copy link
Copy Markdown
Member

Thanks for doing this. I have to be straight about the order: #594 was assigned to @biancamp85 on 19 Sep, before this PR opened. I said on the issue that I do not take a claim back after 24 hours, and I am not making an exception here, because the lesson that leaves is that racing pays. So I am leaving this open rather than closing it: if her translation does not arrive, or she steps back, yours is next. In the meantime the most useful thing you could do is review her PR when it opens, since you have already been through every line of this file yourself. One note so it does not look like something failed: the required checks have not run here yet, they need maintainer approval for a first-time contributor. Nothing is red, it is unmeasured.

@Roberton003

Copy link
Copy Markdown
Contributor

Hi @paulocoutinhox and @cevheri,

The translation structure looks good and keeps the right scope from the other localized READMEs. I spotted a few literal translations that sound unnatural in Brazilian Portuguese and should be adjusted before merging:

  • Line 208: ## Onde fica a linha do cobrança -> ## Onde traçamos a linha de cobrança (or linha de cobrança). "Cobrança" is feminine, so "do cobrança" is a grammar error carried from Spanish.
  • Line 210: Não é um recurso empurrado para trás de um muro. -> Não é um recurso bloqueado atrás de um paywall. Brazilian devs use "paywall" directly; "muro" sounds like an automated translation.
  • Lines 118 and 119: Sentenças que falham / sentenças em execução -> Consultas com falha / Consultas em execução. In Portuguese SQL contexts, queries/statements are "consultas" or "instruções", never "sentenças".
  • Line 138: A superfície principal de IA... -> A interface principal de IA.... "Superfície" is a literal translation of "surface"; in this UI context, we say "interface".

The database tables, code blocks, and the plain-HTTP security warning look consistent with the main README.

@paulocoutinhox

Copy link
Copy Markdown
Author

Fixed.

@cevheri

cevheri commented Sep 25, 2026

Copy link
Copy Markdown
Member

@paulocoutinhox a heads-up so this is ready when #594 is decided on 29 September. Against current main, bun run readme:check fails on two things that landed after you pushed: README_pt.md needs the translation-lag banner above the first heading (README_es.md shows the pattern), and the engine table is missing Prometheus. Rebasing on main and fixing both should be all it takes.

@cevheri cevheri added the documentation Improvements or additions to documentation label Sep 25, 2026
@paulocoutinhox

Copy link
Copy Markdown
Author

done

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants