netapp-nvme: fix uninitialized pointer in netapp_smdevices() - #3651
Open
sahmed-ibm wants to merge 1 commit into
Open
netapp-nvme: fix uninitialized pointer in netapp_smdevices()#3651sahmed-ibm wants to merge 1 commit into
sahmed-ibm wants to merge 1 commit into
Conversation
The netapp_smdevices() function declares the devices pointer used to receive the scandir() output, but does not initialize it before passing its address to scandir(). If execution reaches the scandir() call with devices holding an indeterminate stack value, the behavior is undefined. Initialize devices to NULL so it holds a defined value before scandir() writes to it through the pointer. Signed-off-by: Sarah Ahmed <sarah.ahmed@ibm.com>
Collaborator
|
This commit message is wrong. The namelist parameter is an output parameter. On success, scandir() allocates an array and stores its address in *namelist. On failure, it returns -1. There is no requirement in POSIX that *namelist be initialized before the call. This is just to shut up the analyzer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The netapp_smdevices() function declares the devices pointer used to receive the scandir() output, but does not initialize it before passing its address to scandir().
If execution reaches the scandir() call with devices holding an indeterminate stack value, the behavior is undefined.
Initialize devices to NULL so it holds a defined value before scandir() writes to it through the pointer.