solidigm-telemetry: fix missing fallthrough annotations in debug info switch - #3780
Open
sahmed-ibm wants to merge 1 commit into
Open
solidigm-telemetry: fix missing fallthrough annotations in debug info switch#3780sahmed-ibm wants to merge 1 commit into
sahmed-ibm wants to merge 1 commit into
Conversation
… switch The sldm_debug_info_parse() function uses an intentional fallthrough chain in its segment-ID switch to set @tracker_log_name before reaching the shared tracker parsing body. The DEBUG_INFO_ID_TRACKER_INFO and DEBUG_INFO_ID_TRACKER_BUFFER cases fall through to the next case without a fallthrough annotation. Unannotated fallthrough triggers -Wimplicit-fallthrough warnings from the compiler and is flagged by static analysis tools as a control flow defect (CID 557320, CID 557398). Add fallthrough; after each intentional fall-through to match the convention used throughout the rest of the codebase and suppress the warning. Signed-off-by: Sarah Ahmed <sarah.ahmed@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sldm_debug_info_parse() function uses an intentional fallthrough chain in its segment-ID switch to set tracker_log_name before reaching the shared tracker parsing body. The DEBUG_INFO_ID_TRACKER_INFO and DEBUG_INFO_ID_TRACKER_BUFFER cases fall through to the next case without a fallthrough annotation.
Unannotated fallthrough triggers -Wimplicit-fallthrough warnings from the compiler and is flagged by static analysis tools as a control flow defect (CID 557320, CID 557398).
Add fallthrough; after each intentional fall-through to match the convention used throughout the rest of the codebase and suppress the warning.