test: fix integer overflow when setting SAVE bit in cdw10/cdw11 - #3783
Open
bellis-ibm wants to merge 1 commit into
Open
test: fix integer overflow when setting SAVE bit in cdw10/cdw11#3783bellis-ibm wants to merge 1 commit into
bellis-ibm wants to merge 1 commit into
Conversation
Several __u8, __u16, and bool values are shifted left by 16, 24, or 31 bits without first being promoted to uint32_t. In C, these shifts happen on signed int, causing signed integer overflow (undefined behaviour) when the result sets bit 31 or exceeds 16 bits. Cast each shift operand to uint32_t so the arithmetic stays in the unsigned domain, matching the pattern used elsewhere in the codebase. Fixes Coverity CIDs 557419, 557377, 557388, 557424, 557460, 557498, 557509 (INTEGER_OVERFLOW). Signed-off-by: Brooke Ellis <Brooke.Ellis@ibm.com>
bellis-ibm
force-pushed
the
fix/coverity-integer-overflow
branch
from
August 7, 2026 19:47
baad301 to
2076b23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shifting a bool/int left by 31 bits without first promoting to
uint32_t invokes signed integer overflow (undefined behaviour in C).
Cast the shift operand to uint32_t so the arithmetic happens in the
unsigned domain, consistent with every other SAVE-bit expression
in the file.
Fixes Coverity CIDs 557424 and 557388 (INTEGER_OVERFLOW).
Signed-off-by: Brooke Ellis <Brooke.Ellis.ibm.com>