feat: Argument spec implementation for trustee server role - #40
Open
DonatSzabo wants to merge 1 commit into
Open
feat: Argument spec implementation for trustee server role#40DonatSzabo wants to merge 1 commit into
DonatSzabo wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
richm
reviewed
Aug 27, 2026
| # ==================================================== | ||
|
|
||
| - name: Run argument specs validation tests | ||
| when: ansible_version.full is version('2.10', '>=') |
Contributor
There was a problem hiding this comment.
Suggested change
| when: ansible_version.full is version('2.10', '>=') | |
| when: ansible_version.full is version('2.11', '>=') |
richm
changed the title
Contributor
|
[citest] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancement: Added argument spec and assert role spec validation to the trustee server role. Also wrote tests for it found in tests/tests_invalid_input.
Reason: Because it is a good addition to the linux-system-roles project.
Result: Successfully added it and prepared tests for it. I used AI during this implementation.
Issue Tracker Tickets (Jira or BZ if any): linux-system-roles/postfix#206 https://redhat.atlassian.net/browse/RHELMISC-16008