docs: oss packages criticality (CM-1207)#4155
Open
joanagmaia wants to merge 6 commits into
Open
Conversation
Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
…ticality Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the living OSS packages ADR to replace the prior placeholder criticality approach with a proposed scoring methodology and implementation plan for ranking critical packages.
Changes:
- Adds criticality inputs, weighted percentile scoring, tier budget policy, and spotlight override documentation.
- Documents proposed worker layout and graph-signal computation/ingestion considerations.
- Updates open questions and changelog entries around the new methodology.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
Signed-off-by: Joana Maia <jmaia@contractor.linuxfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request significantly expands and finalizes the methodology for scoring package criticality in the
oss-packagesdomain, replacing the previous placeholder formula with a detailed, defensible approach. It introduces a new section describing the signals, formula, tier allocation policy, and manual override system for identifying critical packages across ecosystems. The documentation is updated to reflect these decisions and clarify open questions.Criticality scoring methodology and related changes:
package_criticality_spotlighttable, allowing manual promotion of packages to critical status with required rationale and auditability.Documentation and tracking updates:
Note
Low Risk
Documentation-only changes to ADR-0001; no runtime, schema, or auth code in this diff.
Overview
Replaces the placeholder critical-package formula in ADR-0001 with a full §Criticality scoring methodology: five signals on
packages_universe(adding transitive dependent count and PageRank centrality), a per-ecosystem percentile-rank blend with tunable weights passed intorank_packages_universe(), and rationale for avoiding min-max and cross-ecosystem comparison.Operational design adds floor + ceiling tier budgets (illustrative npm/Maven/PyPI/crates/Go splits), a
package_criticality_spotlighttable for audited manualis_criticaloverrides after ranking, and a plannedpackages_worker/src/criticality/weekly workflow (in-memory graph from directpackage_dependenciesedges unless deps.dev can supply transitive counts).Tracking updates: scope table marks universe selection decided and methodology proposed; universe section points to the new section instead of a placeholder; open questions add deps.dev transitive/centrality verification; changelog records the addition.
Reviewed by Cursor Bugbot for commit b678dc3. Bugbot is set up for automated code reviews on this repo. Configure here.